Skip to content

Backport broken-pipe test fix to 1.x - #21

Closed
donoghuc with Copilot wants to merge 6 commits into
1.xfrom
copilot/1x-backport-test-fix
Closed

donoghuc with Copilot wants to merge 6 commits into
1.xfrom
copilot/1x-backport-test-fix

Conversation

Copilot AI commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Backport the PR #18 test fix to the 1.x branch. The missing-client-certificate spec now accepts either the expected TLS alert or a broken-pipe socket exception.

  • Test behavior: Match Manticore::ClientProtocolException with bad_certificate or certificate_required, or Manticore::SocketException with Broken pipe.

donoghuc and others added 6 commits December 23, 2024 11:56
* Mark ssl as obsolete plugin config

This commit marks the ssl configuration as obsolete. The docs have been updated
as well as the tests. This change will be rolled out in a 2.0.0 release which
has also been prepped in this work.

* Update based on review

Add a note on where to look for obsolete options, fix whitespace.
* Initial plan

* Migrate CI from Travis to GitHub Actions (main branch)

* regenerate certs and extend ttl

* update for different test expectation

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: donoghuc <cas.donoghue@gmail.com>
…he client doesn't provide its certificate (#18)

In test specification adds the catch of also SocketException for broken pipe, when the client doesn't provide its certificate.
Copilot AI linked an issue Oct 15, 2026 that may be closed by this pull request
@donoghuc
donoghuc changed the base branch from main to 1.x October 15, 2026 22:42
Copilot AI changed the title [WIP] Backport test fix to 1.x Backport broken-pipe test fix to 1.x Oct 15, 2026
Copilot AI requested a review from donoghuc October 15, 2026 22:43
@donoghuc

Copy link
Copy Markdown
Contributor

horrible

@donoghuc donoghuc closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport test fix to 1.x

4 participants