Fix stale iOS Live Activities after app exit - #1265
Draft
Explainfuture wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServersNotifierso connection sessions and Live Activities are cleaned upRoot cause
The iOS implementation kept only
LiveActivityManager.current. That reference is lost when the process exits even though ActivityKit intentionally keeps the Live Activity alive. A later stop request therefore had no activity to end and updates could create duplicates.The project also uses the UIScene lifecycle, where
applicationWillTerminateis not a reliable callback for a user closing the app from the app switcher. In addition, the settings bulk-delete path removed storage entries directly and bypassed the session cleanup performed byServersNotifier.delServer.Impact
Closing ServerBox from the iOS app switcher or deleting the connected server no longer leaves a stale "Connected" Live Activity in the Dynamic Island. Interrupted prior runs are reconciled on the next launch.
Validation
flutter analyze lib testflutter test(462 tests passed)git diff --checkAn iOS/Xcode build was not available on the Windows development host.