feat: bundle rquickjs compatibility facade - #22
Closed
huacnlee wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Codex <codex@openai.com>
Open
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies such as LLRT still request the
rquickjspackage, forcing applications usingquickjs-jitto maintain their own forwarding crate. Bundle that unpublished compatibility facade incompat/rquickjsso a consuming workspace can patchrquickjsto this repository and share the same binding types and VM.Forward the existing compatibility features, document the required root-level Cargo patch and consistent Git revision, and add the crate to the workspace. GPUI Kit PR longbridge/gpui-kit#2903 will consume this facade and remove its local copy. This change does not modify JIT execution or address the mixed-workload performance issue.
Test Plan
cargo check -p rquickjs --features macro,loader,half,futures,parallel,properties,classes,array-buffer(passes; upstream deprecated-feature warnings).git diff --check.