Pin Send button to prevent keyboard toolbar overlap#604
Merged
marionbarker merged 3 commits intodevfrom Apr 26, 2026
Merged
Conversation
Move the Send button out of the scrollable Form and pin it at the bottom using .safeAreaInset(edge: .bottom) in all four remote command views (TRC Bolus, TRC Meal, Loop APNS Bolus, Loop APNS Carbs). The button is now always visible — above the keyboard when it's open, at the bottom when it's closed. Also adds .scrollDismissesKeyboard to allow interactive keyboard dismissal by scrolling. Fixes #602
Member
Author
|
marionbarker
approved these changes
Apr 26, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approve from code review and test.
Tested TRC meal and bolus, Loop carbs and bolus using an SE phone.
Button was nicer and more consistent, no scrolling required with this version compared to version before this PR.
While testing the older version for comparison, the PR branch was updated by merging dev into the branch. No change to PR diffs, but test again anyway. Very nice.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.safeAreaInset(edge: .bottom)in all four remote command viewsThe issue reports that the Send button gets blocked by the keyboard toolbar (trash/dismiss buttons) when a recommended bolus is present and the value has been edited. Rather than reducing padding as suggested in the issue, the Send button is now pinned outside the Form entirely — it stays visible above the keyboard at all times, regardless of form content height or screen size.
Affected views: TRC Bolus, TRC Meal, Loop APNS Bolus, Loop APNS Carbs
Fixes #602