TEST: verify lint CI catches violations (do not merge)#616
Closed
TEST: verify lint CI catches violations (do not merge)#616
Conversation
Runs swiftformat --lint in a Linux container on every PR using the same BuildTools pin (SwiftFormat 0.56.1) and flags as the local Scripts/swiftformat.sh, so CI stays in sync with `swift run swiftformat` on a developer machine. Fails the check on any violation without rewriting files — contributors fix formatting themselves and push, rather than having CI commit back over their branch. BuildTools/.build is cached by Package.resolved hash to keep subsequent runs fast.
Adds a concurrency group so rapid successive pushes to a PR branch don't stack up multiple Lint runs — the in-progress run is cancelled as soon as a newer commit arrives.
Collaborator
|
Close with merge of PR #599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR to verify the lint workflow added in #599 actually flags violations.
Adds
LoopFollow/LintTestThrowaway.swiftwith intentional issues:// LoopFollow\n// LintTestThrowaway.swift)returnExpected: the
Lint / SwiftFormatcheck goes red.Do not merge. Will be closed and the branch deleted once #599 is verified.