tests/runtime: skip the percpu rollback test on a single CPU - #733
Merged
Conversation
The rollback is exercised by a script that errors on the second instance to check the earlier ones roll back; with one possible CPU only one instance is created, so the intentional failure never fires and the run succeeds, which the test reported as a failure. Skip it there instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a host with a single possible CPU,
tests/runtime/percpu.sh's rollback case failed. The case runs a script that errors on the second instance to check the earlier instances roll back, but with one CPU only one instance is ever created, so the intentional failure never fires and therunsucceeds — which the test reported as a failure (seen by a newcomer on a 1-vCPU VM).Guard the case with
nproc --alland skip it when there is only one CPU; the plan stays at 6.Test plan: