Repository navigation
fix(receive): a receive 0 should immediately return, not block - #471
Merged
Merged
Conversation
The fix is slightly more complex because reading from a closed socket should still return a closed-error. fixes: #427 fixes: ledgetech/lua-resty-http#313
Tieske
force-pushed
the
fix/zero-read
branch
3 times, most recently
from
August 30, 2026 11:44
863ed80 to
2523ca6
Compare
alerque
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is slightly more complex because reading from a closed
socket should still return a closed-error.
Due to merge conflicts, this PR is targeted at PR #463
fixes: #427
fixes: ledgetech/lua-resty-http#313
Edit: added another commit to ensure we also test the same case for UDP. This fixes 2 issues encountered;
Reviewing is best done commit by commit.