Skip to content

feat: dragging support for volume slider and closelabel on menu #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxgr-linux merged 2 commits into from
May 22, 2026
Merged

feat: dragging support for volume slider and closelabel on menu #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc8631
add dragging support on Volume Slider
amonhaupt May 20, 2026
b655ebc
add missing close label on menu window
amonhaupt May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pokete/classes/menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import scrap_engine as se

from pokete.base.context import Context
from pokete.base.ui.elements.labels import CloseLabel
from pokete.base.ui.notify import notifier
from pokete.base.ui.views.boxes import InfoBoxView
from pokete.base.ui.views.choose_box import ChooseBoxView
Expand All @@ -21,7 +22,7 @@

class Menu(ChooseBoxView):
def __init__(self):
super().__init__(50, 35, "Menu")
super().__init__(50, 35, "Menu", [CloseLabel(),])
self.playername_input = TextInputBox("Playername:", 17)
self.represent_char_input = TextInputBox("Char:", 1)
self.mods_label = se.Text("Mods", state="float")
Expand Down
5 changes: 4 additions & 1 deletion src/pokete/classes/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ def interact(self, ctx: Context, area_idx: int, event: MouseEvent):
if event.pressed:
self.set_slider(area_idx)
self.__set_setting()
elif event.type == MouseEventType.DRAG_LEFT:
self.set_slider(area_idx)
self.__set_setting()

def change(self, ctx: Context):
"""Changes the current position by a value
Expand All @@ -124,7 +127,7 @@ def change(self, ctx: Context):
self.overview = ctx.overview
ctx = change_ctx(ctx, self)
while True:
action, _ = get_action()
action, _ = get_action()
if (strength := action.get_x_strength()) != 0:
if 0 <= (self.offset + strength) <= self.boundary:
self.set_slider(self.offset + strength)
Expand Down
Loading