Fix z_l->lev rename for OM4 snapshot sources - #756
Conversation
|
I ran this script on with the small data setting and wrote the results to my machine. Here is the dataset it produced: Here is the command I used: |
|
@codex may I have your review? |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@fomo-bot will you review this PR? If you think it's ready to merge, will you approve this? |
|
No code findings in the current diff at I did not approve because the PR is still a draft and GitHub reports What I checked:
Debug info
|
|
@fomo-bot will you review for approval now? |
|
@fomo-bot will you also rebase this change with main? |
The 5-daily snapshot source (1958-2022.OM4p25_5daily_snapshots) exposes the depth-center coordinate as z_l but has no z_i. The old rename gated the z_l->lev rename on z_i being present, so z_l was left intact and downstream rechunking on "lev" failed with a ValueError (issue #450). Extract normalize_vertical_coords() to rename z_l->lev and z_i->ilev independently, and key the interface-info branch on ilev rather than z_i. Behavior is unchanged for the averaged sources (which carry z_i). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dbedd35 to
e9f987e
Compare
|
Rebased PR #756 onto current Debug info
|
The 5-daily snapshot source (1958-2022.OM4p25_5daily_snapshots) exposes the depth-center coordinate as z_l but has no z_i. The old rename gated the z_l->lev rename on z_i being present, so z_l was left intact and downstream rechunking on "lev" failed with a ValueError (issue #450).
Extract normalize_vertical_coords() to rename z_l->lev and z_i->ilev independently, and key the interface-info branch on ilev rather than z_i. Behavior is unchanged for the averaged sources (which carry z_i).
🤖