Skip to content

Added support for Redis host and port arguments - #118

Open
benlong wants to merge 3 commits into
maccman:masterfrom
benlong:master
Open

Added support for Redis host and port arguments#118
benlong wants to merge 3 commits into
maccman:masterfrom
benlong:master

Conversation

@benlong

@benlong benlong commented Jan 27, 2012

Copy link
Copy Markdown

Updated server.js to accept --redisport and --redishost arguments.

Values are passed to listen(), and normalized to defaults. From here forwarded along through the application.

A minor 'refactorish' change: Events.client is no longer created inline. Instead publish inits channel which inits event with proper redis information.

We're using this in production today. I'm interested in feedback/drawbacks of the implementation. I have another patch that allows the use of Redis.namespace for namespaced redis instances.

@felipecsl

Copy link
Copy Markdown

+1 I need this to run juggernaut in rails test environment, which connects to redis in a different port
👍

@snovotny

Copy link
Copy Markdown

+1 this patch works well for connecting to a different host redis is running on

@redterror

Copy link
Copy Markdown

+1

4 similar comments
@kebot

kebot commented Aug 14, 2012

Copy link
Copy Markdown

+1

@barttenbrinke

Copy link
Copy Markdown

+1

@Narnach

Narnach commented Mar 20, 2013

Copy link
Copy Markdown

+1

@codenamev

Copy link
Copy Markdown

+1

@alexandre-mbm

Copy link
Copy Markdown

👍 I was seeing exactly this here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants