base: support min_version check#81
Conversation
|
Should the version check also be reflected in the xbps package dependencies? |
I wouldn't know why, as this is only about xbstrap features used in the bootstrap.yml and not related to the eventual output. |
|
Oh my bad, I thought this was for package dependency versions, not xbstrap's version itself |
|
|
||
| import colorama | ||
| import jsonschema | ||
| import pkg_resources |
There was a problem hiding this comment.
due to this, we now depend on setuptools. consider instead extracting the version into a file that setup.py reads/imports
There was a problem hiding this comment.
What's the problem with depending on setuptools?
There was a problem hiding this comment.
that we don't declare it... plus, decently sure this won't work when doing a distro install. there's simply no need
Maybe the property should be called |
5 participants
No description provided.