Skip to content

[Internal] Fix drawable compositing on API < 23#4166

Open
pubiqq wants to merge 1 commit into
material-components:masterfrom
pubiqq:internal/fix-drawable-compositing
Open

[Internal] Fix drawable compositing on API < 23#4166
pubiqq wants to merge 1 commit into
material-components:masterfrom
pubiqq:internal/fix-drawable-compositing

Conversation

@pubiqq
Copy link
Copy Markdown
Contributor

@pubiqq pubiqq commented May 8, 2024

No description provided.

@leticiarossi
Copy link
Copy Markdown
Contributor

Thank you for the PR! Could you explain what was the issue in APIs<23 and how does your change fix it? Why are you removing the shouldScaleTopLayer check?

@pubiqq
Copy link
Copy Markdown
Contributor Author

pubiqq commented May 10, 2024

This "optimization" is just incorrect. If the desired size is INTRINSIC_SIZE, it doesn't mean that the image doesn't need to be scaled, because the topLayerNewWidth and topLayerNewHeight may differ from the desired ones.

I have no idea why shouldScaleTopLayer was added, it wasn't in the original PR.

@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from 034e8c5 to f385bad Compare August 13, 2024 11:47
@pubiqq pubiqq mentioned this pull request Sep 23, 2024
@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from f385bad to b8215f8 Compare May 12, 2025 20:28
@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch 3 times, most recently from 874c687 to 4c5eca9 Compare June 18, 2025 14:58
@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from 4c5eca9 to 88fc4f7 Compare September 8, 2025 20:57
@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from 88fc4f7 to ee8ae28 Compare March 16, 2026 19:01
@leticiarossi leticiarossi removed their assignment May 5, 2026
@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from ee8ae28 to 0e10090 Compare May 26, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants