Skip to content

fix: validate Connect ServiceRequest handlers#19

Merged
jrandolf merged 1 commit into
mainfrom
jrandolf/fix-connect-impl-service-request
Jun 28, 2026
Merged

fix: validate Connect ServiceRequest handlers#19
jrandolf merged 1 commit into
mainfrom
jrandolf/fix-connect-impl-service-request

Conversation

@jrandolf

Copy link
Copy Markdown
Contributor

Summary

  • teach #[connect_impl] to recognize Connect 0.7 ServiceRequest<'_, Req> handler parameters
  • keep validation injection for the existing OwnedView<_> handler shape
  • add regression coverage for both request forms and update the README example

Root cause

The macro only matched parameter type paths ending in OwnedView. Connect 0.7 generated service impls now receive connectrpc::ServiceRequest<'_, Req>, so the macro skipped those handlers and no longer injected request validation.

Validation

  • cargo test -p protovalidate-buffa --test connect_impl
  • cargo fmt --all -- --check
  • mise x aqua:protocolbuffers/protobuf/protoc@35.1 -- cargo clippy --workspace --all-targets -- -D warnings
  • mise x aqua:protocolbuffers/protobuf/protoc@35.1 -- cargo test --workspace --all-targets

@jrandolf jrandolf merged commit 05dd4ad into main Jun 28, 2026
7 checks passed
@jrandolf jrandolf deleted the jrandolf/fix-connect-impl-service-request branch June 28, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant