chore: collapse CI into single check job - #7
Merged
Merged
Conversation
1.Gate job needed its own runner -> removed it 2.Required check name should stay -> renamed job
There was a problem hiding this comment.
Pull request overview
Simplifies the GitHub Actions CI workflow by making the real verification job the required check job, eliminating the separate gate-only job while preserving the required check name.
Changes:
- Renamed the existing
lint-testjob tocheck(including the displayed job name). - Removed the gate-only
checkjob that depended onlint-test. - Kept the existing
fmt,lint, andteststeps unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the
CIworkflow so the real verification job is the requiredcheckinstead of running a second no-op gate job. This keeps the same required check name while avoiding an extra runner allocation.Changes
lint-testjob tocheckcheckjob that only depended onlint-testfmt,lint, andteststeps unchangedChecklist
Required
make checkpasses (fmt→lint→test)commit-message-instructions.mdConditional (list only those that apply)