fix: include Rowes Wharf stop when filtering by ferry route_type#1020
Open
khansen-mbta wants to merge 1 commit into
Open
fix: include Rowes Wharf stop when filtering by ferry route_type#1020khansen-mbta wants to merge 1 commit into
khansen-mbta wants to merge 1 commit into
Conversation
khansen-mbta
force-pushed
the
kh/include-rowes-wharf
branch
from
2c6ef1f to
6f322ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🐛 🍎 API output not as expected (causes inability to create alerts for Rowes Wharf)
Previously, the Rowes Wharf stop was not being included in the API response for
/stops?filter[route_type]=4. Theroutes_by_stops_and_directionhelper inroute_patterns_at_stop.exdefaulted to select only canonical routes for a given stop ID. This passes an option to check non-canonical routes since some ferry routes do not have patterns marked as canonical. The response now includes Rowes Wharf as well as the previously returned stops as well.