Skip to content

feat: Load ferry timetables from data#3206

Merged
joshlarson merged 2 commits into
mainfrom
jdl/feat/load-ferry-timetables-from-data
May 29, 2026
Merged

feat: Load ferry timetables from data#3206
joshlarson merged 2 commits into
mainfrom
jdl/feat/load-ferry-timetables-from-data

Conversation

@joshlarson
Copy link
Copy Markdown
Contributor

@joshlarson joshlarson commented May 22, 2026

Scope

Asana Ticket: 🏖️⛴️ Update Quincy/Winthrop timetables to be data-based again

This is also a soft blocker for the Harbor Loop Ferry work, since this will allow us to not hard-code data for that timetable.

Implementation

  • See comments in the code for more implementation notes.

Screenshots

Screenshot 2026-05-22 at 6 34 15 PM

How to test

Look at the Quincy and Winthrop timetables, and compare them against their production Quincy and Winthrop counterparts.

@joshlarson joshlarson force-pushed the jdl/feat/load-ferry-timetables-from-data branch from d3c8d4a to 12e73a6 Compare May 27, 2026 21:17
@joshlarson joshlarson force-pushed the jdl/feat/load-ferry-timetables-from-data branch from 12e73a6 to df1f2a3 Compare May 28, 2026 01:12
@joshlarson joshlarson marked this pull request as ready for review May 28, 2026 01:15
@joshlarson joshlarson requested a review from a team as a code owner May 28, 2026 01:15
@joshlarson joshlarson requested a review from jlucytan May 28, 2026 01:15
@joshlarson joshlarson enabled auto-merge (squash) May 28, 2026 01:15
@joshlarson joshlarson disabled auto-merge May 28, 2026 17:08
@joshlarson joshlarson added the dev-green Deploy to dev-green label May 29, 2026
@joshlarson joshlarson enabled auto-merge (squash) May 29, 2026 15:08
Copy link
Copy Markdown
Contributor

@lvachon1 lvachon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some cool code, I like how generalized it is. I bet we'll find an exception to these elegant rules at some point, but I can see this being useful for more than just these loops. I think this kind of "merge schedules with different stops into a timetable" function would've made the weird WC CR shuttles trivial.

@joshlarson joshlarson merged commit 35bdac5 into main May 29, 2026
22 checks passed
@joshlarson joshlarson deleted the jdl/feat/load-ferry-timetables-from-data branch May 29, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-green Deploy to dev-green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants