chore: extract Upcoming Departures into a LiveView#3219
Open
thecristen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
I got tired of navigating the gigantic codebase of
DotcomWeb.ScheduleFinderLive, and I think Upcoming Departures has enough of its own thing going on that it could be extracted. You can render child LiveViews within parent LiveViews. So now here is a new LiveView, dedicated to Upcoming Departures.Implementation
Most of the code was migrated as-is*. I moved a few smaller functional components into separate files, so that other files could easily import them. I added some more documentation in various spots.
*I changed the computation of the last trip time, slightly. Just felt like we could use a simpler query.
*I also slightly adjusted it to use
start_async/3andhandle_async/3instead ofassign_async/3, felt easier to reason about and try to capture errors forScreenshots
No change! This should result in no visible changes from the current implementation.
How to test
No idea, but there are a few new tests covering some of the upcoming departures functionality now!