Support an individual fullname #720

[stellargela]

add #720

[mdjnelson]

Can you please squash these commits into one? Thanks.

[mdjnelson]

Also, please address this issues found in GitHub Actions. Cheers. :)

[stellargela]

Hi,
I hope, I fixed all the issues now. Cheers :)

[mdjnelson]

This looks good. However, I would not have a global setting for these but I would put it as an option in the element. The core plugin should not know or care about the settings of elements. :)

[mwreichel]

Hi @mdjnelson,
thank you for your feedback to the fixed version of @stellargela.

So would it be ok for you if we implement these admin settings to the elements in the same way instead?

Our approach with an admin setting in the core plugin was to define a global naming scheme. In our case the defined scheme should be used automatically by any element plugin and editing users shouldn't be able to define the scheme on their own.

Thanks in advance,
Martin

[mdjnelson]

Thanks for explaining the use case. I understand why you want a site-wide certificate name format, and I’m fine with that being configured by an administrator rather than by each editing teacher.

My concern is where the logic lives. This behaviour is specific to the studentname and teachername certificate elements, so I’d prefer the settings and formatting logic to live inside the relevant element plugin(s), not in the core mod_customcert plugin. The core plugin should not need to know that these particular elements have a custom fullname policy, nor should it contain helper classes/settings that only those elements use.

mod_customcert already supports element plugins loading their own settings: after the main customcert settings, it creates the customcertelements category and calls each customcert element plugin’s load_settings() method. So an admin-level, globally enforced setting can still be implemented, but it should be owned by the element plugin rather than by mod_customcert itself. This keeps the separation clean: core provides the certificate/element framework, while each element owns its own rendering policy.

In this PR, the new mod_customcert\fullname_certificate class and the customcert/fullname + customcert/fullnameformat settings are added to the core plugin, but the settings are only consumed by the studentname and teachername elements. That creates coupling between core and specific element behaviour. If another name-related element wanted similar behaviour later, we’d either have to keep expanding core or make the global setting mean different things for different elements.

Could you move this into the relevant element plugin(s) instead? For example, the element plugin could expose the admin setting, contain the formatting helper, and use it consistently in both PDF rendering and HTML preview. The setting can still be global/admin-controlled, so editing users do not need to choose the format per certificate element.

Thanks for your patience and hard work! :)