fix: tolerate a FAT entry that points past the file under Permissive - #91
Open
francisdb wants to merge 1 commit into
Open
fix: tolerate a FAT entry that points past the file under Permissive#91francisdb wants to merge 1 commit into
francisdb wants to merge 1 commit into
Conversation
A FAT entry pointing beyond the last sector rejected the whole file even when no chain ran through it. Under Permissive validation the entry now ends its chain instead, so only a stream that actually uses that sector is truncated. Strict validation still rejects the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
A FAT entry pointing beyond the last sector rejected the whole file even when no chain ran through it, unlike the neighbouring FAT and DIFAT marker checks, which repair under
Permissive. The entry now ends its chain underPermissive, so only a stream that actually uses that sector is affected (its read fails withUnexpectedEof);Strictstill rejects the file with the same message.Ending the chain rather than marking the sector free keeps it off the free list, so it cannot be handed out for new data, and a chain reaching it truncates instead of erroring on the walk.
Tests include the reproduction from the issue, its
Strictcounterpart, and a case where a live chain runs through the bad entry.