Pioarduino 3.3.11 - #11238
Conversation
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (31)
Build artifacts expire on 2026-08-29. Updated for |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ESP32 configurations update platform dependencies, enable mbedTLS SHA-512, add an ESP-IDF NimBLE include path, and retarget the SenseCAP Indicator Arduino-ESP32 framework. ChangesESP32 configuration updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fixed by:
|
84b11f8 to
3e8f5c1
Compare
d8e8674 to
59bb35c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
variants/esp32/esp32-common.ini (1)
9-10: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the forked PlatformIO source to an immutable commit.
The active URL uses
refs/heads/55.03.311.zip, so builds follow a branch rather than a fixed revision. A branch rewrite could silently change the ESP32 toolchain; prefer an archive generated from a commit SHA, or record and verify the branch SHA in CI. GitHub distinguishes branch archives from stable commit archives. (docs.github.com)Suggested change
- https://github.com/meshtastic/pioarduino-platform-espressif32/archive/refs/heads/55.03.311.zip + https://github.com/meshtastic/pioarduino-platform-espressif32/archive/<verified-commit-sha>.zip🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@variants/esp32/esp32-common.ini` around lines 9 - 10, Update the active pioarduino PlatformIO source URL to use an immutable commit-SHA archive instead of the mutable refs/heads/55.03.311.zip branch archive, while preserving the existing fork and platform version source selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@variants/esp32/esp32-common.ini`:
- Around line 9-10: Update the active pioarduino PlatformIO source URL to use an
immutable commit-SHA archive instead of the mutable refs/heads/55.03.311.zip
branch archive, while preserving the existing fork and platform version source
selection.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 591f2e5a-afcd-41bb-ac67-05efbb76d8f3
📒 Files selected for processing (1)
variants/esp32/esp32-common.ini
Update pioarduino from 3.3.9 to 3.3.11 There was no 3.3.10 pioarduino release Release notes: - https://github.com/pioarduino/platform-espressif32/releases/tag/55.03.311 - https://github.com/espressif/arduino-esp32/releases/tag/3.3.10 - https://github.com/espressif/arduino-esp32/releases/tag/3.3.11
59bb35c to
8cb8b72
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
variants/esp32/esp32-common.ini (1)
9-10: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the platform dependency to an immutable revision.
The active URL resolves the mutable
55.03.311branch, so later branch changes could silently alter the toolchain without a PR change. Prefer a commit archive, or verify that this branch is intentionally immutable and matches the tested release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@variants/esp32/esp32-common.ini` around lines 9 - 10, Update the active platform dependency URL in esp32-common.ini to reference an immutable commit archive instead of the mutable 55.03.311 branch. Preserve the tested platform revision and leave the existing fallback URL unchanged unless it also needs the same pinning.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@variants/esp32/esp32-common.ini`:
- Around line 9-10: Update the active platform dependency URL in
esp32-common.ini to reference an immutable commit archive instead of the mutable
55.03.311 branch. Preserve the tested platform revision and leave the existing
fallback URL unchanged unless it also needs the same pinning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 87b9b3fa-2e5e-43fd-af3c-8f59e9fa2bc6
📒 Files selected for processing (2)
variants/esp32/esp32-common.inivariants/esp32/esp32.ini
|
Whenever there's a new arduino-esp32 version we have to compare all changed SDKCONFIG settings in the generated |
|
I found the following new definition of interest but no changed values during comparison: CONFIG_ARDUINO_SELECTIVE_ESP_Video=y So we may remove it until we support video: |
3 participants
Update pioarduino from 3.3.9 to 3.3.11
There was no 3.3.10 pioarduino release
Release notes:
(Better) Release notes: https://release-notes.espressif.com/release/3.3.11?project=Arduino
Summary by CodeRabbit
Summary by CodeRabbit
Chores
Security
Improvements