change tsconfig moduleResolution to bundler#4969
Merged
Merged
Conversation
added 2 commits
July 14, 2026 16:33
…to `bundler` in `tsconfig.json`.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UI TypeScript configuration to use bundler-aligned module resolution (Vite) to eliminate the deprecated moduleResolution=node/node10 warning reported in #4968, and performs the accompanying versioning/changelog updates.
Changes:
- Switch
ui/app/tsconfig.jsonmoduleResolutionfromnodetobundler. - Bump UI package version to
0.8.28(including lockfile). - Add a BUG FIXES entry to
CHANGELOG.mdreferencing #4968.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/app/tsconfig.json | Updates TypeScript module resolution strategy to bundler to align with Vite and remove the deprecation warning. |
| ui/app/package.json | Increments the UI package version to reflect the change. |
| ui/app/package-lock.json | Keeps lockfile version metadata consistent with the UI package version bump. |
| CHANGELOG.md | Documents the deprecation-warning fix under BUG FIXES with an issue reference. |
Files not reviewed (1)
- ui/app/package-lock.json: Generated file
Unit Test Results241 tests 241 ✅ 27s ⏱️ Results for commit 226efbe. ♻️ This comment has been updated with latest results. |
marrobi
approved these changes
Jul 15, 2026
Member
|
/test-force-approve 226efbe |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 226efbe) (in response to this comment from @marrobi) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4968
What is being addressed
The current moduleResolution setting of "node" (node10) is deprecated, since we are using vite as a bundler then moduleResolution should be updated to "bundler"
How is this addressed