Skip to content

Add SetReferenceType method to SignedXml and SignedXmlImpl (#10139) #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marco Antonio Mauro (marcus905) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SetReferenceType method to SignedXml and SignedXmlImpl (#10139) #10212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/System Application/App/Cryptography Management/src/Xml/SignedXml.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,15 @@ codeunit 1460 SignedXml
SignedXmlImpl.InitializeReference(Uri);
end;

/// <summary>
/// Sets the type Uniform Resource Identifier (URI) of the current Reference.
/// </summary>
/// <param name="Type">The type URI of the current Reference.</param>
procedure SetReferenceType(Type: Text)
begin
SignedXmlImpl.SetReferenceType(Type);
end;

/// <summary>
/// Sets the digest method Uniform Resource Identifier (URI) of the current Reference.
/// </summary>
Expand Down
5 changes: 5 additions & 0 deletions src/System Application/App/Cryptography Management/src/Xml/SignedXmlImpl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ codeunit 1461 "SignedXml Impl."
DotNetReference := DotNetReference.Reference(Uri);
end;

procedure SetReferenceType(Type: Text)
begin
DotNetReference.Type := Type;
end;

procedure SetDigestMethod(DigestMethod: Text)
begin
DotNetReference.DigestMethod := DigestMethod;
Expand Down
37 changes: 37 additions & 0 deletions src/System Application/Test/Cryptography Management/src/Xml/SignedXmlModuleTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,43 @@ codeunit 132612 "Signed Xml Module Test"
LibraryAssert.IsTrue(SignedXml.CheckSignature(CertBase64Data, Password, true), 'Failed to verify the xml signature.');
end;

[Test]
procedure SetReferenceType()
var
SignatureKey: Codeunit "Signature Key";
XmlToSign: XmlDocument;
KeyText: SecretText;
Signature: XmlElement;
NamespaceMgr: XmlNamespaceManager;
Node: XmlNode;
SignatureNamespaceUriTok: Label 'http://www.w3.org/2000/09/xmldsig#', Locked = true;
ReferenceTypeTok: Label 'http://uri.etsi.org/01903#SignedProperties', Locked = true;
begin
XmlDocument.ReadFrom('<XmlData Id="ID01">This is a document</XmlData>', XmlToSign);
GetSignatureKeyXmlString(KeyText);
SignatureKey.FromXmlString(KeyText);

SignedXml.InitializeSignedXml(XmlToSign);
SignedXml.SetSigningKey(SignatureKey);
SignedXml.InitializeReference('#ID01');
SignedXml.SetReferenceType(ReferenceTypeTok);
SignedXml.AddReferenceToSignedXML();

SignedXml.ComputeSignature();
Signature := SignedXml.GetXml();

NamespaceMgr.AddNamespace('ns', SignatureNamespaceUriTok);
Signature.SelectSingleNode(
'./ns:SignedInfo/ns:Reference/@Type',
NamespaceMgr,
Node);

LibraryAssert.AreEqual(
ReferenceTypeTok,
Node.AsXmlAttribute().Value,
'Incorrect reference type was applied.');
end;

[Test]
procedure SetXmlDSigC14NTranform()
var
Expand Down
Loading