-
Notifications
You must be signed in to change notification settings - Fork 436
[Master]-ACY amount on Value Entries is recalculated from LCY when the document currency equals the Additional Reporting Currency, causing a mismatch with G/L Entries #10231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
neeleshsinghal
wants to merge
2
commits into
main
from
bugs/Bug-646085-ACY-amount-on-Value-Entries-is-intact-from-LCY
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the APAC layer only, the new ShouldUseDocumentAmountForACY() branch sets PurchVarACY := 0, but the final PurchVarACY assignment (near line 3722,
PurchVarACY := ItemJnlLine."Unit Cost (ACY)" * ItemJnlLine."Invoiced Quantity" - DirCostACY - OvhdCostACY;) sits outside that conditional and always executes afterward regardless of which branch was taken. This silently overwrites the zeroed PurchVarACY, defeating the document-amount path and producing an incorrect ACY purchase variance for costing-method-driven ACY postings. Although agent findings are capped at minor severity, the underlying impact is major/blocker-level (wrong posted amounts) and should be fixed before merge. Note that the sibling layers (W1, CH, ES, IT, RU) do not have this bug: their equivalent code correctly nests the PurchVarACY calculation inside the else-branch of ShouldUseDocumentAmountForACY(), so only APAC needs the fix. The recommended fix moves the final PurchVarACY assignment inside the non-document-amount else branch (mirroring the other layers' structure) so it only recomputes PurchVarACY for the CalcACYAmt/CurrExchRate fallback path.Suggested fix (apply manually — could not be anchored as a one-click suggestion):
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4