Implement business activity code to EU from Italy localization by Alexander-Ya · Pull Request #10233 · microsoft/BCApps

Alexander Yakunin (Alexander-Ya) · 2026-08-13T13:35:26Z

What & why

Linked work

Fixes #

How I validated this

I read the full diff and it contains only changes I intended.
I built the affected app(s) locally with no new analyzer warnings.
I ran the change in Business Central and confirmed it behaves as expected.
I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

…Implement-Business-Activity-Code-from-IT

github-actions · 2026-08-13T13:37:03Z

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

github-actions · 2026-08-13T13:49:06Z

+        BusinessActivityValidator.Validate(Code);
+    end;
+
+    [IntegrationEvent(false, false)]


$\textbf{🟡\ Medium\ Severity\ —\ Events}$

The new integration event OnGetValidator (codeunit "Business Activity Code Mgt.") does not encode its firing position or host routine per the publisher-naming convention, so a subscriber cannot tell from the symbol name where/when it fires relative to Validate(). Consider a position-encoding name such as OnValidateOnBeforeGetBusinessActivityValidator or similar.

Knowledge:

microsoft/knowledge/events/name-events-by-publisher-position.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T13:49:08Z

+
+    fields
+    {
+        field(1; Code; Code[10])


$\textbf{🟠\ High\ Severity\ —\ Privacy}$

New table 395 "Business Activity" declares DataClassification = CustomerContent at table scope but leaves both Normal fields (Code and Description) without their own field-level DataClassification. AS0016 requires the field-level property regardless of the table-level default.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

field(1; Code; Code[10]) { Caption = 'Code'; DataClassification = CustomerContent; NotBlank = true; trigger OnValidate() var BusinessActivityCodeMgt: Codeunit "Business Activity Code Mgt."; begin BusinessActivityCodeMgt.Validate(Code); end; } field(2; Description; Text[100]) { Caption = 'Description'; DataClassification = CustomerContent; }

Knowledge:

microsoft/knowledge/privacy/table-level-data-classification-cascades.md

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T13:49:09Z

                SetBrandColorValue();
            end;
        }
+        field(395; "Business Activity Code"; Code[10])


$\textbf{🟠\ High\ Severity\ —\ Privacy}$

157 new "Business Activity Code" fields added across changed table/tableextension objects omit an explicit DataClassification (for example Company Information, Purchase Header, Gen. Journal Line). AS0016 requires every Normal field to declare its own DataClassification; relying on the table-level DataClassification leaves these fields effectively unclassified for AppSourceCop/privacy tooling purposes.

Knowledge:

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

microsoft/knowledge/privacy/table-level-data-classification-cascades.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T13:49:11Z

+        UpgradeTag.SetUpgradeTag(UpgradeTagDefinitions.GetBusinessActivityCodeUpgradeTag());
+    end;
+
+    local procedure CopyBusinessActivityCodeField(TableId: Integer; ActivityCodeFieldId: Integer)


$\textbf{🟠\ High\ Severity\ —\ Upgrade}$

IT's UpgradeBusinessActivityCodes() calls CopyBusinessActivityCodeField(TableId, ActivityCodeFieldId) for 25 tables, and the helper hard-codes the destination field number to 12189 (DataTransfer.AddFieldValue(ActivityCodeFieldId, 12189)). Only "Periodic VAT Settlement Entry" actually defines field 12189 as "Business Activity Code". Verified: "General Ledger Setup", "VAT Setup", "VAT Statement Line", and "VAT Statement Name" do not define field 12189 at all in this diff (their new field is 395, and for VAT Setup/Statement Line/Name it isn't even the same field: 395 there is "Per Business Activity Code Settl. Entry" (Boolean) or "Business Activity Code Filter", not a plain code copy target). Calling DataTransfer.CopyFields() against a nonexistent destination field 12189 will fail at runtime for these tables, breaking the IT upgrade path; the remaining ~20 tables that do use field 395 for "Business Activity Code" will silently copy into field 12189 (also nonexistent there), so no upgraded company gets its data migrated into the real field 395.

Knowledge:

microsoft/knowledge/upgrade/datatransfer-for-bulk-init.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:20Z

+    begin
+        if Code = '' then
+            exit;
+


$\textbf{🟠\ High\ Severity\ —\ Events}$

The new publisher OnGetValidator (internal IntegrationEvent in Business Activity Code Mgt.) uses an ad-hoc name that doesn't encode its position relative to the host procedure Validate, so subscribers cannot tell from the name alone that it fires before dispatch/validation. Rename the publisher (and its IT event subscriber) to an OnBefore.../OnAfter... shape that reflects where it fires within Validate.

Knowledge:

microsoft/knowledge/events/name-events-by-publisher-position.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:22Z

            Editable = false;
            FieldClass = FlowField;
        }
+        field(395; "Business Activity Code"; Code[10])


$\textbf{🟠\ High\ Severity\ —\ Privacy}$

The PR adds roughly 150+ new 'Business Activity Code' (Code[10]) fields across W1 and country-layer journal, document, archive, history, VAT, and company tables (for example src/Layers/W1/BaseApp/Sales/Document/SalesHeader.Table.al, .../Purchases/Document/PurchaseHeader.Table.al, and .../Finance/GeneralLedger/Journal/GenJournalLine.Table.al) without a DataClassification property. These fields default to ToBeClassified, leaving new business/customer data unreviewed for GDPR/telemetry purposes across dozens of shipped tables in one PR.

Knowledge:

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

microsoft/knowledge/privacy/table-level-data-classification-cascades.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:24Z

$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The changed file src/Layers/IT/BaseApp/Permissions/local.permissionset.al does not follow the ..al convention: both the object segment (local) and the type segment (permissionset) are lower-cased, hurting discoverability by tooling.

Knowledge:

microsoft/knowledge/style/file-name-object-type-pattern.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:25Z

$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The changed file src/Layers/IT/BaseApp/Permissions/localread.permissionset.al does not follow the ..al convention: both the object segment (localread) and the type segment (permissionset) are lower-cased.

Knowledge:

microsoft/knowledge/style/file-name-object-type-pattern.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:26Z

$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The changed file src/Layers/IT/BaseApp/Service/Local/History/ServiceInvoiceHeaderIT.tableExt.al uses a lower-cased type suffix (tableExt) instead of the canonical TableExt segment required by the ..al pattern.

Knowledge:

microsoft/knowledge/style/file-name-object-type-pattern.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T14:31:27Z

microsoft/knowledge/style/xmldoc-for-public-library-procedures.md

+
+codeunit 12102 "Business Activity Code Mgt."
+{
+    procedure Validate(Code: Code[10])


$\textbf{🟡\ Medium\ Severity\ —\ Style}$

The new 'Business Activity Code Mgt.' codeunit exposes a public Validate procedure without XML documentation. Add ///
and /// comments describing the contract and behavior for consumers of this new reusable entry point.

Knowledge:

microsoft/knowledge/style/xmldoc-for-public-library-procedures.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

Co-authored-by: Alexander-Ya <179119309+Alexander-Ya@users.noreply.github.com>

…://github.com/microsoft/BCApps into bugs/Implement-Business-Activity-Code-from-IT

github-actions · 2026-08-13T19:50:52Z

$\textbf{🟡\ Medium\ Severity\ —\ Breaking\ Changes}$

Table 12136 "Periodic VAT Settlement Entry" adds the replacement field "Business Activity Code", but the shipped field 1 "Activity Code" remains live with no ObsoleteState, ObsoleteReason, or ObsoleteTag. Keep the original field readable and mark it Pending so dependent extensions get the standard deprecation window before CLEAN29 cleanup.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

        field(1; "Activity Code"; Code[6])
        {
            Caption = 'Activity Code';
            ObsoleteReason = 'Replaced by the Business Activity Code field.';
            ObsoleteState = Pending;
            ObsoleteTag = '29.0';
        }

Knowledge:

microsoft/knowledge/breaking-changes/obsolete-table-fields-instead-of-deleting-them.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T19:50:53Z

+        field(12189; "Business Activity Code"; Code[10])
+        {
+            Caption = 'Business Activity Code';
+        }


$\textbf{🟡\ Medium\ Severity\ —\ Data\ Modeling}$

The new "Business Activity Code" field on "Periodic VAT Settlement Entry" lacks TableRelation = "Business Activity".Code even though every other new "Business Activity Code" field in this PR carries that relation. This drops lookup/validation for the field and allows codes that do not exist in table 395.

Suggested change

field(12189; "Business Activity Code"; Code[10])

{

Caption = 'Business Activity Code';

}

field(12189; "Business Activity Code"; Code[10])

{

Caption = 'Business Activity Code';

TableRelation = "Business Activity".Code;

}

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T19:50:55Z

            Editable = false;
            FieldClass = FlowField;
        }
+        field(395; "Business Activity Code"; Code[10])


$\textbf{🟠\ High\ Severity\ —\ Privacy}$

The PR adds 179 new Normal "Business Activity Code" fields across changed tables/tableextensions without a field-level DataClassification, relying on table scope instead. BCQuality's AS0016 guidance requires every Normal field to declare DataClassification explicitly rather than inheriting it from the table.

Knowledge:

microsoft/knowledge/privacy/table-level-data-classification-cascades.md

microsoft/knowledge/privacy/data-classification-required-on-pii-fields.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T19:50:57Z

    end;

+#if not CLEAN29
+    local procedure UpgradeBusinessActivityCodes()


$\textbf{🟡\ Medium\ Severity\ —\ Telemetry}$

UpgradeBusinessActivityCodes() introduces a one-time migration that creates Business Activity rows and bulk-copies the new field into many tables, but it emits no Session.LogMessage telemetry before setting the upgrade tag, leaving no upgrade-time observability for whether it ran and how much data it moved. Add explicit upgrade telemetry for this procedure (at minimum a stable event id plus success/skip/failure context and migrated row counts) before the upgrade tag is set.

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

github-actions · 2026-08-13T19:50:59Z

    end;

+#if not CLEAN29
+    local procedure UpgradeBusinessActivityCodes()


$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

The new validator paths are exercised in src/Layers/IT/Tests/Local/ITActivityCode.Codeunit.al, but this PR also adds UpgradeBusinessActivityCodes() plus 24 CopyBusinessActivityCodeField() migrations and none of the changed test files seeds legacy Activity Code data or verifies that the upgrade both creates Business Activity rows and copies old field values into the new Business Activity Code fields. Add an upgrade test that runs the upgrade against pre-upgrade data and asserts both the table migration and the DataTransfer-based field copy — this would also have caught the field-id mismatch bug found elsewhere in this review.

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4}

Alexander Yakunin (Alexander-Ya) added 3 commits August 13, 2026 14:26

Implement Business Activity Code from IT to W1

59b2ac4

Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…

51d8d45

…Implement-Business-Activity-Code-from-IT

Propagate changes

083ad87

Alexander Yakunin (Alexander-Ya) requested review from a team August 13, 2026 13:35

Alexander Yakunin (Alexander-Ya) deployed to triage August 13, 2026 13:35 — with GitHub Actions Active

github-actions Bot added Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction labels Aug 13, 2026

github-actions Bot reviewed Aug 13, 2026

View reviewed changes

Add missing APAC change

47b5a9c

github-actions Bot reviewed Aug 13, 2026

View reviewed changes

Copilot started work on behalf of Alexander Yakunin (Alexander-Ya) August 13, 2026 18:12 View session

Fix AL0792 unused usings breaking Apps AT build

4cd164d

Co-authored-by: Alexander-Ya <179119309+Alexander-Ya@users.noreply.github.com>

Copilot finished work on behalf of Alexander Yakunin (Alexander-Ya) August 13, 2026 18:18

github-actions Bot added needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Aug 13, 2026

Alexander Yakunin (Alexander-Ya) added 2 commits August 13, 2026 21:32

Fix compile errors

f6def32

Merge branch 'bugs/Implement-Business-Activity-Code-from-IT' of https…

5bd6b69

…://github.com/microsoft/BCApps into bugs/Implement-Business-Activity-Code-from-IT

github-actions Bot reviewed Aug 13, 2026

View reviewed changes

Uh oh!

Conversation

Alexander Yakunin (Alexander-Ya) commented Aug 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Linked work

How I validated this

Risk & compatibility

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Alexander Yakunin (Alexander-Ya) commented Aug 13, 2026 •

edited by github-actions Bot

Loading