Support HY-MT evaluation workflows#2482
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables HY-MT evaluation workflows by tightening lm-eval/ORT-GenAI integration: it preserves recipe-provided bootstrap_iters, normalizes ORT GenAI provider names and mirrors the exported past_present_share_buffer setting at runtime, prevents model-loading-only kwargs from leaking into generation config loading, and extends accelerator tests with WebGPU coverage.
Changes:
LMEvaluatornow forwards a configurablebootstrap_iterstolm_eval.simple_evaluate.LMEvalORTGenAIEvaluatormaps Olive EP names to ORT GenAI provider names, readspast_present_share_bufferfromgenai_config.json, and renamesdeviceto_device.HfMixin.get_hf_generation_configfilters outtorch_dtype/device_map/max_memory/quantization_configbefore callingget_generation_config.- New accelerator normalization tests for WebGPU in both skip-EP-check and runtime-required paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| olive/evaluator/olive_evaluator.py | Adds bootstrap_iters plumbing into LMEvaluator and simple_evaluate. |
| olive/evaluator/lmeval_ort.py | Adds ORT GenAI provider name normalization, runtime past_present_share_buffer, and renames self.device to self._device. |
| olive/model/handler/mixin/hf.py | Excludes model-load-only kwargs when loading HF generation config. |
| test/hardware/test_accelerator.py | Adds WebGPU coverage for accelerator normalization skip/required paths. |
xiaoyu-work
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation