Fix input validation issues and update multiple-choice options handling#2501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the ONNX TieWordEmbeddings graph surgery to be more compatible with exported model interfaces by recognizing "inputs_embeds" as an additional valid input name (alongside "input_ids" and "input_embeds").
Changes:
- Extend
TieWordEmbeddings.__call__input name detection to include"inputs_embeds". - Update the inline comment to reflect the supported input-name variants.
xiaoyu-work
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling of multiple-choice questions and options extraction in the data preprocessing and evaluation pipeline, as well as a minor enhancement to ONNX model input handling. The main changes include switching from numeric to letter-based multiple-choice options, extracting the selected letter during evaluation, and supporting an additional input name in ONNX graph surgeries.
Multiple-choice options handling:
pre_process_data.pyto format multiple-choice options using letters (A, B, C, ...) instead of numbers, and added a new fieldextract_option_letterto indicate when letter extraction is needed. [1] [2]olive_evaluator.pyto extract the selected letter from model responses for multiple-choice questions, in addition to the previous digit extraction. This ensures compatibility with the new letter-based formatting. [1] [2] [3]ONNX model input handling:
TieWordEmbeddingsclass ingraph_surgeries.pyto support bothinput_embedsandinputs_embedsas valid input names, improving compatibility with different model variants.