Add canonical SDK major targets - #1269
Open
Gudge (MGudgin) wants to merge 1 commit into
Open
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 24, 2026
Gudge (MGudgin)
added this pull request to stack #1257
September 24, 2026 22:08
Gudge (MGudgin)
force-pushed
the
user/gudge/rust-sdk-phase14a
branch
from
September 25, 2026 18:53
51d3af0 to
d965962
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Prerelease contracts currently make a valid stable SDK target impossible at the planned v1.1 development boundary.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds canonical SDK-major contract targets and validates them against the Rust contract registry.
Changes:
- Adds
sdkMajorTargetsmetadata and validation. - Adds validator tests.
- Documents contract authority and SDK target behavior.
| File | Description |
|---|---|
scripts/versioning/tests/contract-registry.test.js |
Tests SDK target validation. |
scripts/versioning/lib/contract-registry.js |
Implements target validation. |
scripts/versioning/check-schema-versions.js |
Integrates validation into version checks. |
schemas/schema-version.json |
Adds canonical target mapping. |
docs/versioning.md |
Documents SDK target semantics. |
docs/schema-codegen.md |
Documents registry-based validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This PR adds canonical SDK-major-to-exact-contract target metadata and validates it against the exact Rust contract registry. Details * Add the canonical `sdkMajorTargets` mapping without predeclaring a v1 target. * Require each SDK major to target its latest published stable exact contract. * Exclude development, prerelease, and build-metadata contracts from target candidates while retaining them in the full registry. * Cover mutable development, development-only major lines, build metadata, and stable advancement in the registry tests. * Document that opening prerelease development does not advance an SDK target; publishing the next stable contract does. * Document Rust contract authority and defer compatibility and API baselines until real v1 artifacts exist. Tests * `npm test` in `scripts/versioning` (67 passed) * `npm run check-schema-versions` * `npm run check-contract-codegen` * `git diff --check` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d91874d-feea-4a33-b183-67d506ae61b5 Generated-with: gpt-5.6-sol
Gudge (MGudgin)
force-pushed
the
user/gudge/rust-sdk-phase14a
branch
from
September 25, 2026 20:26
d965962 to
24ab161
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds canonical SDK-major-to-exact-contract target metadata and validates
it against the exact Rust contract registry.
Details
sdkMajorTargetsmapping without predeclaring a v1 target.contract.
until real v1 artifacts exist.
Tests
cargo check --workspace --all-targets --all-featuresvalidation before publication.
Microsoft Reviewers: Open in CodeFlow