This repository was archived by the owner on Nov 13, 2026. It is now read-only.
Repository navigation
MODIS: Remove XML metadata dependency - #351
Merged
Merged
Conversation
Karthick Narendran (karthick-rn)
requested a review
from Gustavo Hidalgo (ghidalgo3)
December 17, 2025 14:32
Gustavo Hidalgo (ghidalgo3)
approved these changes
Dec 18, 2025
4 tasks done
DerekTan1
added a commit
that referenced
this pull request
Oct 15, 2026
Since #351 moved to stactools-modis 8854ceb, items carry no projection: the new stactools builder only reads projection from COGs passed to it, and this collection attaches COGs afterwards with add_cogs/add_cog_assets. Read the projection once per item from the local HDF's first subdataset (every MODIS asset shares one sinusoidal tile grid), as stactools-modis did before. Use WktVersion.WKT2_2019 explicitly: to_wkt("WKT2") passed the string as morph_to_esri_dialect, so older items stored ESRI WKT1. Co-authored-by: Derek Tan <tanderek@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccc413ed-d53b-400b-8314-a0aa9a9f48f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the past, MODIS dataset includes both .hdf and .xml files as part of onboarding. This changed and .xml file is no longer included. This PR will remove the dependency on the XML. The repo that provides modis package had been updated via stactools-packages/modis#97
Fixes # Modis Ingestion
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ingestion tested against a product and verified the stac item created successfully for it.
https://planetarycomputer.microsoft.com/explore?c=-134.4503%2C55.3138&z=4.32&v=2&d=modis-43A4-061&m=cql%3A5f2d6e100cd82009329bc4df3e51de56&r=Natural+color&s=false%3A%3A100%3A%3Atrue&sr=desc&ae=0
Checklist:
Please delete options that are not relevant.