Remove Deprecated use of url.parse by rajmishra1997 · Pull Request #389 · microsoft/typed-rest-client

rajmishra1997 · 2025-12-24T15:16:23Z

Deprecation in Node 24: https://nodejs.org/api/deprecations.html#DEP0169

This PR updates use of url.parse to Safer New URL()
Impacts how request object is formed by rest-client

Copilot

Pull request overview

This PR migrates from the deprecated Node.js url.parse() API (deprecated in Node 24 as DEP0169) to the WHATWG URL() constructor. The changes update URL parsing logic across the HTTP client library to use the modern URL API while attempting to preserve existing behavior.

Changes:

Replaced url.parse() with new URL() constructor throughout the codebase
Updated type signatures from url.Url to URL in interfaces and method signatures
Refactored URL merging logic in Util.getUrl() to handle relative and absolute URLs with the new API
Added error handling for invalid URLs during parsing

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
lib/Util.ts	Refactored getUrl() function to use URL constructor, with logic to detect and handle relative vs absolute resource URLs, manual URL construction for path merging
lib/Interfaces.ts	Updated IRequestInfo interface to use URL type instead of url.Url
lib/HttpClient.ts	Updated all url.parse() calls to new URL(), changed type signatures, replaced url.format() with .href property
test/units/utiltests.ts	Updated test cases to use new URL() instead of url.parse()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rajmishra1997 · 2026-03-22T14:33:50Z

/azp run

azure-pipelines · 2026-03-22T14:34:06Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rajmishra1997 · 2026-03-22T16:49:45Z

/azp run

azure-pipelines · 2026-03-22T16:49:58Z

Azure Pipelines successfully started running 1 pipeline(s).

rajmishra1997 · 2026-03-22T16:53:57Z

/azp run

azure-pipelines · 2026-03-22T16:54:08Z

Azure Pipelines successfully started running 1 pipeline(s).

sanjuyadav24 · 2026-03-24T11:20:47Z

+            } else {
+                // Resource is a relative path - merge with base using path.resolve
+                const protocol = base.protocol;
+                const encodedUsername = base.username ? encodeURIComponent(base.username) : '';


username and password here can contain special characters?

Yes, urlstores username/password in decoded form (e.g., %40 becomes @). When we reconstruct the URL string manually, we must use
encodeURIComponent() to re-encode special character

azure-pipelines · 2026-05-05T06:44:24Z

Azure Pipelines: Successfully started running 1 pipeline(s).

azure-pipelines · 2026-05-05T10:53:24Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rajmishra1997 · 2026-05-18T09:45:03Z

/azp run

azure-pipelines · 2026-05-18T09:45:14Z

Azure Pipelines successfully started running 1 pipeline(s).

raujaiswal · 2026-05-18T10:31:38Z

    }

-    private _isMatchInBypassProxyList(parsedUrl: url.Url): Boolean {
+    private _isMatchInBypassProxyList(parsedUrl: URL): Boolean {


can we please check if we can use boolean here that is primitive type instead of object Type Boolean?

raujaiswal · 2026-05-18T10:45:54Z

 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.

 import url = require("url");


can we please check if we need this url import in this file and other file since we removed url.parse?

rajmishra1997 requested review from a team as code owners December 24, 2025 15:16

tarunramsinghani reviewed Dec 26, 2025

View reviewed changes

Comment thread lib/HttpClient.ts

rajmishra1997 changed the title ~~Remove Deprecated use of url.parse~~ [Draft]Remove Deprecated use of url.parse Dec 29, 2025

rajmishra1997 requested a review from tarunramsinghani December 29, 2025 11:04

tarunramsinghani approved these changes Jan 6, 2026

View reviewed changes

rajmishra1997 requested a review from Copilot February 27, 2026 06:49

Copilot started reviewing on behalf of rajmishra1997 February 27, 2026 06:50 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Comment thread lib/Util.ts Outdated

Comment thread lib/Util.ts Outdated

Comment thread lib/HttpClient.ts Outdated

rajmishra1997 changed the title ~~[Draft]Remove Deprecated use of url.parse~~ Remove Deprecated use of url.parse Mar 22, 2026

rajmishra1997 requested a review from Copilot March 22, 2026 14:33

Copilot started reviewing on behalf of rajmishra1997 March 22, 2026 14:34 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Comment thread lib/Util.ts Outdated

Comment thread lib/Interfaces.ts

Comment thread lib/HttpClient.ts Outdated

Comment thread lib/HttpClient.ts Outdated

rajmishra1997 requested a review from Copilot March 22, 2026 16:27

Copilot started reviewing on behalf of rajmishra1997 March 22, 2026 16:29 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Comment thread lib/HttpClient.ts

Comment thread test/units/utiltests.ts

Comment thread lib/Util.ts

Comment thread lib/Util.ts

Comment thread lib/Util.ts

Comment thread lib/HttpClient.ts

Comment thread lib/HttpClient.ts

Comment thread lib/Interfaces.ts

rajmishra1997 requested a review from tarunramsinghani March 22, 2026 16:49

sanjuyadav24 reviewed Mar 24, 2026

View reviewed changes

gaborcsardi mentioned this pull request May 8, 2026

r-lib/actions/setup-r gives (node:2740) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. r-lib/actions#1074

Closed

tarunramsinghani mentioned this pull request May 12, 2026

Fix: Cast proxy port to Number to prevent CONNECT hang under Node 24 #397

Open

rajmishra1997 and others added 2 commits May 18, 2026 14:53

Remove deprecated use of url.parse

be5d499

Update redirect URL

04fbb48

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rajmishra1997 and others added 4 commits May 18, 2026 14:53

Update auth handling of URL construction

b53c79a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update error handling

2158af9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestions from code review

58efab8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update error messages to not include urls

8d411cc

rajmishra1997 force-pushed the users/rajmishra/RemoveURL branch from dc853e3 to 8d411cc Compare May 18, 2026 09:25

Normalize proxy urls and update catch exceptions

83bb49c

rajmishra1997 requested a review from sanjuyadav24 May 18, 2026 09:45

Fix deafult ports for proxy url

d31ccc7

raujaiswal reviewed May 18, 2026

View reviewed changes

Uh oh!

Conversation

rajmishra1997 commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajmishra1997 commented Mar 22, 2026

Uh oh!

azure-pipelines Bot commented Mar 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajmishra1997 commented Mar 22, 2026

Uh oh!

azure-pipelines Bot commented Mar 22, 2026

Uh oh!

rajmishra1997 commented Mar 22, 2026

Uh oh!

azure-pipelines Bot commented Mar 22, 2026

Uh oh!

sanjuyadav24 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

rajmishra1997 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented May 5, 2026

Uh oh!

azure-pipelines Bot commented May 5, 2026

Uh oh!

rajmishra1997 commented May 18, 2026

Uh oh!

azure-pipelines Bot commented May 18, 2026

Uh oh!

raujaiswal May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raujaiswal May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rajmishra1997 commented Dec 24, 2025 •

edited

Loading

raujaiswal May 18, 2026 •

edited

Loading

raujaiswal May 18, 2026 •

edited

Loading