Skip to content

Add default installer precedence if not defined by user#6123

Merged
JohnMcPMS merged 10 commits intomicrosoft:masterfrom
Trenly:Precedence
Apr 29, 2026
Merged

Add default installer precedence if not defined by user#6123
JohnMcPMS merged 10 commits intomicrosoft:masterfrom
Trenly:Precedence

Conversation

@Trenly
Copy link
Copy Markdown
Contributor

@Trenly Trenly commented Apr 2, 2026

This PR adds a default order of precedence for installer types if the user has not specified one. This ensures that ordering in a manifest is less important. While this has the potential to cause some upset with publishers who would prefer a different default order, the linked issue can remain open for tracking those requests.

Future work could involve merging the default preferences with user preferences so that any installer types the user has not specified as their preference still adhere to this default ordering, but I presumed that to be out of scope for this feature


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner April 2, 2026 20:28
@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 2, 2026

@jsoref - I'm not sure I understand why this error is coming up, when it didn't come up on PRs from a few days ago and nothing has changed in the workflow file. Any advice?

@jsoref
Copy link
Copy Markdown
Contributor

jsoref commented Apr 3, 2026

Unfortunately the only choices are updating to the prerelease version (pinned by sha) or adding a guard that skips check-spelling for PRs where the base repo doesn't match the head repo (the check only applies in that case).

Comment thread src/AppInstallerCommonCore/Manifest/ManifestComparator.cpp
@Trenly Trenly requested a review from JohnMcPMS April 28, 2026 13:08
Comment thread doc/Settings.md Outdated
Comment thread doc/ReleaseNotes.md Outdated
Comment thread src/AppInstallerCommonCore/Manifest/ManifestComparator.cpp Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Author-Feedback Issue needs attention from issue or PR author Needs-Attention Issue needs attention from Microsoft and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Apr 28, 2026
Trenly and others added 2 commits April 28, 2026 17:19
Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
@Trenly Trenly requested a review from JohnMcPMS April 28, 2026 22:34
@JohnMcPMS
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit 2e56941 into microsoft:master Apr 29, 2026
9 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Attention Issue needs attention from Microsoft label Apr 29, 2026
@Trenly Trenly deleted the Precedence branch April 29, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants