Publish abi3 wheels; fix C++ linking in source builds#7
Merged
Conversation
Wheels were tagged cp39-cp39 (CPython 3.9 only) despite the abi3 intent, so Python 3.10+ always built from the sdist. Pass py_limited_api to bdist_wheel (as BinPackage does) so a single cp39-abi3 wheel covers CPython 3.9+. Also force the C++ link driver on Linux source builds: recent setuptools links C++ extensions with the C driver, omitting libstdc++ and failing at import with 'undefined symbol: __gxx_personality_v0'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Published wheels are tagged
cp39-cp39(CPython 3.9 only), despite the abi3 intent intrie_build.pyand the CI comments. Every consumer on Python 3.10+ therefore compiles icegrams from the sdist. Recent setuptools links C++ extensions with the C driver, omittinglibstdc++, so those source builds now fail at import time withundefined symbol: __gxx_personality_v0(seen in Docker deploys onpython:3.14-slim).Changes
setup.py: passpy_limited_api = "cp39"tobdist_wheelon CPython (mirrors BinPackage), so cibuildwheel produces a singlecp39-abi3wheel covering CPython 3.9+.trie_build.py: extend the existing PyPy linker workaround to Linux CPython source builds, forcing the C++ link driver solibstdc++is always linked.Verification
Built locally: wheel comes out
icegrams-1.1.7-cp39-abi3-macosx_15_0_arm64.whl(previouslycp39-cp39). Installed that wheel into a Python 3.14 venv: import succeeds and trigram lookups work.