Upload every file in a multi-file drop, not just the first - #74
Open
jhalter wants to merge 1 commit into
Open
Conversation
The Files view drop handlers pulled items.first out of the provider array and discarded the rest, so dropping N files from Finder uploaded exactly one. The handler still returned true, so the drop animated as accepted and the remaining files vanished silently. Loop over every provider instead. The three call sites that have FileActions share a new upload(droppedItems:to:) helper; FolderItemView has its own upload path and loops inline. Also fixes the security-scoped resource lifetime in the same handlers: access was released by a defer that fired as soon as the upload was enqueued, while the transfer was still in flight. It now releases from the upload's completion instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the files pane would accept multiple files for upload, but only one of the files would actually transfer.
Here's a proposed fix.