blake2: reject a digest size below 1 - #166
Merged
Merged
Conversation
Make_BLAKE2 only checked the upper bound on digest_size, so a size below 1 (e.g. -1) was accepted; in the C backend it wraps to a uint8_t (255) and finalise writes past the caller's destination buffer. Reject digest_size < 1 as well, in both the C and pure-OCaml backends.
Member
|
Thanks. |
jmid
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jul 14, 2026
CHANGES: - Remove DKML CI (@jonahbeckford, @dinosaure, mirage/digestif#159, mirage/digestif#160, mirage/digestif#161) - Fix documentation (@kit-ty-kate, @dinosaure, mirage/digestif#162) - Reject bad digest size for BLAKE2 implementation (@samoht, @dinosaure, mirage/digestif#166) - Delete old artifact for MirageOS 3.0 (@dinosaure, @vbgl, mirage/digestif#165, mirage/digestif#168) - Be safe aligned on ARM architecture (@dinosaure, @hannesm, mirage/digestif#169)
craff
pushed a commit
to craff/opam-repository
that referenced
this pull request
Jul 25, 2026
CHANGES: - Remove DKML CI (@jonahbeckford, @dinosaure, mirage/digestif#159, mirage/digestif#160, mirage/digestif#161) - Fix documentation (@kit-ty-kate, @dinosaure, mirage/digestif#162) - Reject bad digest size for BLAKE2 implementation (@samoht, @dinosaure, mirage/digestif#166) - Delete old artifact for MirageOS 3.0 (@dinosaure, @vbgl, mirage/digestif#165, mirage/digestif#168) - Be safe aligned on ARM architecture (@dinosaure, @hannesm, mirage/digestif#169)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make_BLAKE2only checks the upper bound ondigest_size, so a size below 1 (e.g.-1) is accepted; in the C backend it wraps to auint8_t(255) andfinalisewrites past the caller's destination buffer. Rejectdigest_size < 1as well, in both the C and pure-OCaml backends.