-
Notifications
You must be signed in to change notification settings - Fork 0
SUPP-144: Disambiguate Try It endpoint names for profile APIs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /groups#group-unset | ||
| title: Delete Property | ||
| title: Delete Group Profile Property | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /groups#group-remove-from-list | ||
| title: Remove from List Property | ||
| title: Remove from Group Profile List Property | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /groups#group-set-once | ||
| title: Set Property Once | ||
| title: Set Group Profile Property Once | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /groups#group-set | ||
| title: Update Property | ||
| title: Update Group Profile Property | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /groups#group-union | ||
| title: Union To List Property | ||
| title: Union to User Profile List Property | ||
| --- | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /engage#profile-unset | ||
| title: Delete Property | ||
| title: Delete User Profile Property | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /engage#profile-list-remove | ||
| title: Remove from List Property | ||
| title: Remove from User Profile List Property | ||
| --- |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /engage#profile-set-once | ||
| title: Set Property Once | ||
| title: Set User Profile Property Once | ||
| --- | ||
| Works just like "\$set", except it will not overwrite existing property values. This is useful for properties like "First login date". |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| --- | ||
| openapi: /openapi/ingestion.openapi.yaml POST /engage#profile-union | ||
| title: Union To List Property | ||
| title: Union to Group Profile List Property | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This file ( |
||
| --- | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
group-union.mdxwas given the titleUnion to User Profile List Property, whileuser-profile-union.mdxwas givenUnion to Group Profile List Property— the qualifiers are inverted. The group endpoint should read "Group Profile" and the user endpoint should read "User Profile", not the other way around. As-is, the dropdown will show each endpoint under the wrong context, which is exactly the problem the PR was meant to fix.