perf(tools): optimize stale count in gen-catalogue-status.py - #463
perf(tools): optimize stale count in gen-catalogue-status.py#463mjmirza wants to merge 2 commits into
Conversation
Batch stale entry timestamp lookup into a single git log query instead of spawning individual git log subprocesses for each file. Add unit tests for stale_count in gen-catalogue-status-test.py. Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Precompile module-level regular expressions, guard header checks with
line.startswith('#'), and eliminate setdefault dictionary overhead
during section parsing in extract_frontmatter_and_sections().
Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
1 participant
Problem & Reproduction
tools/gen-catalogue-status.pyexecutedstale_count()by runningsubprocess.run(["git", "log", "-1", ...])sequentially for every published pattern entry (890+ files). Spawning 890 individualgitsubprocesses introduced ~3.3 seconds of unnecessary execution overhead every timemake catalogueormake checkwas run.Solution
Optimized
stale_count()to run a single batchedgit logquery (git log --format=TS:%ct --name-only -- patterns). The function streams through the log lines, captures the latest timestamp for each published pattern file, and exits early once all entries are resolved.Evidence & Performance
stale_count()across 890 files.stale_count().Testing & Verification
tools/gen-catalogue-status-test.pytestingstale_count()behavior when.gitis missing and when computing stale vs fresh timestamps.make test.PR created automatically by Jules for task 11583114675505867809 started by @mjmirza