Repository navigation
Augment errors with stacktraces where they come from from different contexts #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cstorey-monzo
merged 15 commits into
master
from
extend-cross-process-or-routine-stacktraces
Jan 28, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5e8e969
Add tests for stack trace propagation.
cstorey-monzo f095dec
Properly test the previous stack chaining representation.
cstorey-monzo cc4fde2
Avoid repeating stack where we do not need to.
cstorey-monzo 473d121
Ensure we do not needlessly repeat stack traces, but allow for regula…
cstorey-monzo e6d20f4
Be more precise, and only fallback to filename / method comparison fo…
cstorey-monzo 2adc39a
Update comment.
cstorey-monzo 5ab6806
Use the hopefully clearer "Ancestry" in place of "Root"
cstorey-monzo 594eabc
Add String() method to stacks.
cstorey-monzo 19cd480
This could be an approval test, but i do not want to pull in more bit…
cstorey-monzo 8f16d67
Start on some additional stack frames.
cstorey-monzo ee9bce2
Fix logic bug in terms of which one we are okay with being longer.
cstorey-monzo 3bff696
More unit tests, and flip the logic to hopefully make it make more se…
cstorey-monzo c0ee6cf
Name the various frame comparisions we do.
cstorey-monzo ccd611c
A little context.
cstorey-monzo bb03536
Add missing test case.
cstorey-monzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might be being dense.
In that example, the PC for the two traces will be different, no? One will be pointing at the call to
something, and the other will be the call toterrors.Augment.Will we not always return false on the first frame? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd hope that my tests demonstrate otherwise :) You're right that the PC check would always fail on the first frame, which is why we fall back to comparing the file and method names down on line 110. Does that help at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♀️
thisFrame.PC != otherFrame.PC && thisFrame.Filename != otherFrame.Filename && thisFrame.Method != otherFrame.MethodI was being dense - this returns false if all of them don't match, not if any of them don't match. (Yes, the tests were a clue I was missing something. 😆)
But I'm still not sure I understand the intent behind this check. If the filename matches, but the method doesn't, we consider it a match. Do we not want something like: