Repository navigation
MAF-21397: chore(deploy)!: remove the moai-inference-framework chart - #192
Merged
Merged
Conversation
The chart only shipped the ECR token refresher and kubernetes-replicator after the observability stack and NFD moved out. Clusters that pull from ECR now apply a standalone refresher manifest instead. It writes the moreh-registry pull secret to its own namespace and to every namespace labeled mif=enabled, so the replicator is no longer needed. Remove the chart, its publish and CD workflows, the helm-docs check, and the Makefile. Document the standalone refresher in Prerequisites and drop the chart from the docs, agent rules, and release skill. Observability and NFD docs that still assume the chart are left for MAF-21406. BREAKING CHANGE: the moai-inference-framework chart is no longer published. Apply the ECR token refresher from Prerequisites, then uninstall the release. Clusters that pull through Harbor only need the uninstall. Refs: MAF-21397 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UXJtxnZmGp1KRx5ZtL9L7
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The privileged refresher uses a mutable third-party image, and several changed documentation paths remain incorrect for Harbor and logging users.
3 open findings
What changed in this PR
Removes the retired umbrella Helm chart and replaces its registry authentication component with a standalone ECR token refresher.
Changes:
- Deletes the chart, publishing workflows, and Helm tooling.
- Adds standalone ECR secret refresh instructions and updates installation documentation.
- Updates operator skills and release guidance for independently published charts.
| File | Description |
|---|---|
website/docs/operations/monitoring/logs/index.mdx |
Updates the removed prerequisite anchor. |
website/docs/operations/latest-release.mdx |
Removes the framework chart table. |
website/docs/operations/container-image-caching-with-harbor/index.mdx |
Documents refresher removal for Harbor. |
website/docs/getting-started/quickstart.mdx |
Updates pull-secret propagation guidance. |
website/docs/getting-started/prerequisites.mdx |
Adds the standalone ECR refresher manifest. |
website/AGENTS.md |
Updates documentation examples and chart rules. |
skills/guide-odin/SKILL.md |
Documents standalone Odin values. |
skills/guide-heimdall/SKILL.md |
Updates installation ordering. |
Makefile |
Removes chart maintenance targets. |
deploy/helm/moai-inference-framework/values.yaml |
Removes chart values. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/serviceaccount.helm.yaml |
Removes refresher service accounts. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/secret.helm.yaml |
Removes credential Secret templates. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/rolebinding.helm.yaml |
Removes RoleBindings. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/role.helm.yaml |
Removes Roles. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/job.helm.yaml |
Removes the initialization Job. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/cronjob.helm.yaml |
Removes the refresher CronJob. |
deploy/helm/moai-inference-framework/templates/ecr-token-refresher/_helpers.tpl |
Removes refresher helpers. |
deploy/helm/moai-inference-framework/templates/_helpers.tpl |
Removes chart helpers. |
deploy/helm/moai-inference-framework/README.md.gotmpl |
Removes the README template. |
deploy/helm/moai-inference-framework/README.md |
Removes generated chart documentation. |
deploy/helm/moai-inference-framework/Chart.yaml |
Removes chart metadata. |
deploy/helm/moai-inference-framework/Chart.lock |
Removes locked dependencies. |
deploy/helm/moai-inference-framework/.helmignore |
Removes chart ignore rules. |
deploy/helm/AGENTS.md |
Removes obsolete chart guidance. |
AGENTS.md |
Removes references to chart guidance. |
.tool-versions |
Removes helm-docs. |
.github/workflows/release-chart/action.yaml |
Removes the chart publishing action. |
.github/workflows/pr-checker.yaml |
Removes chart documentation validation. |
.github/workflows/cd-mif-stage.yaml |
Removes release-candidate chart publishing. |
.github/workflows/cd-mif-prod.yaml |
Removes production chart publishing. |
.github/workflows/cd-mif-dev.yaml |
Removes development chart publishing. |
.agents/skills/release/SKILL.md |
Updates release procedures after chart removal. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…l the images Drop the ECR token refresher manifest and its steps from Prerequisites. The section now only says that Moreh provides AWS IAM credentials and that the images can be pulled with them. Point Quickstart and the Harbor guide at the renamed section and drop the refresher removal step. Refs: MAF-21397 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UXJtxnZmGp1KRx5ZtL9L7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAF-21397. After #191 the
moai-inference-frameworkchart only shipped the ECR token refresher andkubernetes-replicator. This PR removes the chart. Prerequisites now only states that Moreh provides AWS IAM credentials and that the images can be pulled with them. How a cluster turns those credentials into image pulls (a pull secret refresher, a Harbor proxy cache, and so on) is left to the operator.Changes
deploy/and the chart'sdeploy/helm/AGENTS.md, thecd-mif-{dev,stage,prod}workflows, therelease-chartaction, thepr-checkerworkflow (it only ran helm-docs), theMakefile, andhelm-docsfrom.tool-versions.moai-inference-frameworksection with a short Container image access section: the private ECR repository, and the AWS IAM credentials Moreh provides to pull from it.helm repo add morehinto the Odin section and add--create-namespacetoodin-crd, since the chart no longer creates themifnamespace first.framework-bundled-versionsauto-generated block stays (see follow-up).AGENTS.md,website/AGENTS.md: drop the Helm Charts references.guide-odin: describe the standalonemoreh/odinchart with top-level values.guide-heimdall: update the install order.Breaking change
The chart is no longer published. Existing installs keep running, but nothing upgrades them. Before you
helm uninstallthe release, set up another way to pull with the AWS IAM credentials. Once the release is gone, its refresher no longer renews themoreh-registrysecret, and the token expires within 12 hours.Follow-up
MAF-21406 covers the docs that still assume the chart:
framework-bundled-versionsauto-generated block in Latest release, which needs a matching change on the automation side.Test plan
cd website && npm run build: no broken links or anchors.guide-odinvalues keys against the publishedodinv0.13.0 chart.🤖 Generated with Claude Code