Skip to content

docs+feat: Image transfer KT and single approval-based workflow - #1786

Draft
Ivanmeneges wants to merge 9 commits into
release-1.2.0.1from
cursor/image-transfer-handover-plan-9728
Draft

docs+feat: Image transfer KT and single approval-based workflow#1786
Ivanmeneges wants to merge 9 commits into
release-1.2.0.1from
cursor/image-transfer-handover-plan-9728

Conversation

@Ivanmeneges

@Ivanmeneges Ivanmeneges commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Docs + workflow design for image transfer KT, handover, and approval-based transfer in a single YAML (no per-hop workflow files required).

Approval model (what you asked)

Yes — one workflow is enough. Multiple YAMLs are optional UX, not a security need.

Updated .github/workflows/image-transfer.yml:

  • Input TRANSFER_TARGET (choice) = GitHub Environment name
  • Job waits on environment: ${{ inputs.TRANSFER_TARGET }} for Approve/Reject
  • Destination org is derived from the target (not free-typed)
  • Uses Environment secret DOCKER_TOKEN (same name, different value per Environment)

Removed earlier image-transfer-dev2.yml / image-transfer-qa.yml examples.

Changes needed to go live (UI + process)

  1. Create Environments: transfer-dev2, transfer-qa, transfer-mosipint, transfer-mosipid, Inji targets…
  2. Per Environment: required reviewers + prevent self-review + secret DOCKER_TOKEN
  3. Merge this workflow; operators pick TRANSFER_TARGET after images.txt PR merge
  4. Remove old repo-level MOSIP*_DOCKER_TOKEN once gates work

Guide: release/docs/image-transfer-approval-single-workflow.md

Also in this PR

  • Image transfer KT with merged-PR scenarios
  • Handover plan / Environments how-to / WG approval test guide
  • Vidivi README updated for new inputs

Note: Environments/secrets must be created in GitHub UI by a repo admin before the approval wait works.

Open in Web Open in Cursor 

Document how to hand over stage-to-stage image transfers from DevOps
to Dev and QA with least privilege, approvals, audit, and stage-scoped
workflows while keeping prod under Release/Security control.

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Add a full how-to for GitHub Environments (approval gates + env secrets)
and stage-scoped workflows for mosipdev2 and mosipqa transfers.

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
@cursor cursor Bot changed the title docs: Image transfer handover plan (Dev/QA with controls) docs: Image transfer handover + GitHub Environments how-to Aug 5, 2026
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Comment thread .github/workflows/image-transfer-dev2.yml Fixed
Comment thread .github/workflows/image-transfer-qa.yml Fixed
cursoragent and others added 4 commits August 10, 2026 06:33
Explain how to add environment: wg-lifecycle to mosip/infra's WireGuard
workflow as a safe first dry-run of required-reviewer approvals.

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Document the as-is MOSIP/Inji image transfer process end-to-end, including
images.txt format, workflow cheat sheet, and real PR scenarios
(dev→dev2, dev2→qa, qa→int, mosipid, Inji).

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
@cursor cursor Bot changed the title docs: Image transfer handover + GitHub Environments how-to docs: Image transfer KT, handover plan, and Environments how-to Sep 3, 2026
Comment thread .github/workflows/image-transfer-dev2.yml Fixed
Comment thread .github/workflows/image-transfer-qa.yml Fixed
Replace free-form SECRET_NAME/DESTINATION_ORGANIZATION with TRANSFER_TARGET
bound to GitHub Environments. One YAML maps target → destination org and
uses Environment secret DOCKER_TOKEN after required-reviewer approval.
Remove per-hop workflow files; document the single-workflow approach.

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Explain that Write is needed to open PRs and run workflows, but merge
can be blocked via branch protection, CODEOWNERS, and push restrictions.

Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants