docs+feat: Image transfer KT and single approval-based workflow - #1786
Draft
Ivanmeneges wants to merge 9 commits into
Draft
docs+feat: Image transfer KT and single approval-based workflow#1786Ivanmeneges wants to merge 9 commits into
Ivanmeneges wants to merge 9 commits into
Conversation
Document how to hand over stage-to-stage image transfers from DevOps to Dev and QA with least privilege, approvals, audit, and stage-scoped workflows while keeping prod under Release/Security control. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add a full how-to for GitHub Environments (approval gates + env secrets) and stage-scoped workflows for mosipdev2 and mosipqa transfers. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Explain how to add environment: wg-lifecycle to mosip/infra's WireGuard workflow as a safe first dry-run of required-reviewer approvals. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Document the as-is MOSIP/Inji image transfer process end-to-end, including images.txt format, workflow cheat sheet, and real PR scenarios (dev→dev2, dev2→qa, qa→int, mosipid, Inji). Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
Replace free-form SECRET_NAME/DESTINATION_ORGANIZATION with TRANSFER_TARGET bound to GitHub Environments. One YAML maps target → destination org and uses Environment secret DOCKER_TOKEN after required-reviewer approval. Remove per-hop workflow files; document the single-workflow approach. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
This was referenced Sep 7, 2026
Explain that Write is needed to open PRs and run workflows, but merge can be blocked via branch protection, CODEOWNERS, and push restrictions. Co-authored-by: Ivanmeneges <Ivanmeneges@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs + workflow design for image transfer KT, handover, and approval-based transfer in a single YAML (no per-hop workflow files required).
Approval model (what you asked)
Yes — one workflow is enough. Multiple YAMLs are optional UX, not a security need.
Updated
.github/workflows/image-transfer.yml:TRANSFER_TARGET(choice) = GitHub Environment nameenvironment: ${{ inputs.TRANSFER_TARGET }}for Approve/RejectDOCKER_TOKEN(same name, different value per Environment)Removed earlier
image-transfer-dev2.yml/image-transfer-qa.ymlexamples.Changes needed to go live (UI + process)
transfer-dev2,transfer-qa,transfer-mosipint,transfer-mosipid, Inji targets…DOCKER_TOKENTRANSFER_TARGETafterimages.txtPR mergeMOSIP*_DOCKER_TOKENonce gates workGuide:
release/docs/image-transfer-approval-single-workflow.mdAlso in this PR
Note: Environments/secrets must be created in GitHub UI by a repo admin before the approval wait works.