Repository navigation
Conversation
This also merges the snapshot action method into the generic action method in the handler and backend. However, this commit is meant as an intermediate state: I actually aim to implement a button for the motion event start/stop action. And this can toggle recordings, too. Other than `emulate_motion`, the actions stop a recording immediately, but they also trigger motion notifications, which might not be always wanted. `emulate_motion` is tied with the picture capture mode, too, if enabled, causing all frames to be stored. So depending on which features are enabled, things are tied with each other differently, and we might end up with separate start/stop recording (of pictures and/or movies), and start/stop motion buttons, labelled differently, depending on which features are enabled. Similar to the snapshot button, the visibility of recording/motion toggle buttons would depend on the selected movie recording mode, a separate toggle. The visibility of the motion toggle button, if both really make sense separately, could be a separate toggle in motion detection settings, and a `@manual_motion` config. Leaving this for further testing/clarification and other opinions. Signed-off-by: MichaIng <micha@dietpi.com>
This was
linked to
issues
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also merges the snapshot action method into the generic action method in the handler and backend.
However, this commit is meant as an intermediate state: I actually aim to implement a button for the motion event start/stop action. And this can toggle recordings, too. Other than
emulate_motion, the actions stop a recording immediately, but they also trigger motion notifications, which might not be always wanted.emulate_motionis tied with the picture capture mode, too, if enabled, causing all frames to be stored. So depending on which features are enabled, things are tied with each other differently, and we might end up with separate start/stop recording (of pictures and/or movies), and start/stop motion buttons, labelled differently, depending on which features are enabled. Similar to the snapshot button, the visibility of recording/motion toggle buttons would depend on the selected movie recording mode, and a separate toggle. The visibility of the motion toggle button, if both really make sense separately, could be a separate toggle in motion detection settings, and a@manual_motionconfig.Leaving this for further testing/clarification and other opinions.