Add Bruno imports and a file-tree importer API

[gschier]

Yaak importers currently receive a text string, which cannot represent Bruno collection directories or ZIP exports. Add onImportFiles(ctx, { files }) with lazy readDir, binary readFile, and UTF-8 readTextFile access for single files, ZIPs, directories, and pasted text. Keep onImport backwards compatible but deprecated, with a one-time migration warning; the file hook takes precedence when both exist.

Add Bruno imports for bundled OpenCollection YAML, YAML collection directories/ZIPs, and legacy .bru collections using Bruno’s official file parser. Preserve folders, environments, common auth, and HTTP/GraphQL/gRPC/WebSocket requests. Desktop gains a folder picker; desktop, URL, and CLI import paths preserve binary input and use the existing import planning and linked-reimport flow.

Validation:

• Upstream compatibility: two unchanged Bruno collections (.bru and YAML), pinned to usebruno/bruno@4eb7e585, now exercise real upstream inputs. All 48 Bruno tests and the importer TypeScript/lint checks pass. Source attribution and the MIT license are included; embedded scripts are not executed.
• Full JavaScript suite: 63 files / 804 tests passed, including ZIP/directory equivalence, binary reads, invalid archives, and legacy-hook compatibility.
• Review follow-up: 60 focused runtime/Bruno tests, targeted TypeScript/lint checks, and runtime build passed. ZIP classification covers misleading extensions, extensionless ZIPs, empty archives, and malformed signatures.
• Native import tests: 33 passed; input-loader tests: 2 passed. API and targeted TypeScript/lint checks, runtime/plugin builds, and CLI build passed.
• Actual CLI imports of bundled YAML, ZIPs, .bru directories, and an OpenAPI fixture passed in an isolated data directory. Linked reimport preserved request IDs without duplicates.
• Desktop Rust check passed with packaging-resource checks disabled for a missing local build asset. Desktop UI was not manually tested.

The picker still selects one file or folder; arbitrary multi-select is not included. Collection scripts are not executed, unsupported settings are retained for manual migration, and referenced file paths may need adjustment. ZIPs are detected by signature and read without extraction, with path and size limits. Directory path validation is best-effort under concurrent filesystem changes: a symlink swap can redirect a read or listing outside the selected root. This remains a documented limitation, not a security confinement guarantee; plugins already run with normal Node.js filesystem permissions.

Related: OpenCollection, Bruno file parser.

[greptile-apps]

Confidence Score: 5/5

The latest changes appear safe to merge; no new actionable regressions were identified, although the existing non-blocking directory symlink race remains outstanding.

Findings

1.  Directory checks can race ▶

Summary

The PR adds a file-tree importer API and Bruno collection support across desktop, URL, and CLI import paths.

• Exposes lazy binary and text access for individual files, directories, ZIP archives, and pasted input.
• Preserves legacy text importers while preferring the new file-aware hook.
• Imports bundled OpenCollection documents and legacy Bruno directory or ZIP collections.
• The latest changes classify ZIPs by signature instead of filename and clarify that directory path validation is not a race-free security boundary.
• Adds focused coverage for misleading extensions, extensionless and empty ZIPs, and malformed signatures.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Desktop, URL, CLI, or pasted input] --> B[ImportRequest]
  B --> C{Input type}
  C -->|Directory| D[Lazy filesystem tree]
  C -->|File or download| E{ZIP signature}
  E -->|Yes| F[Lazy ZIP tree]
  E -->|No| G[Single-file tree]
  C -->|Pasted text| G
  D --> H[onImportFiles]
  F --> H
  G --> H
  G --> I[Legacy onImport when file is UTF-8]
  H --> J[Importer resources]
  I --> J
  J --> K[Import planning and linked reimport]
  K --> L[Commit selected changes]

Loading

_{Reviews (2) · Last reviewed commit: "Detect import ZIPs by signature and clar..."}

[greptile-apps]

Directory checks can race

If an intermediate directory is replaced with a symlink after resolve() validates it but before opendir() or open() uses the returned path, the operation can follow that symlink outside the selected root. O_NOFOLLOW only protects the final file component and does not protect readDir, so a plugin could list or read files outside the selected source. This conflicts with the file-tree API's confinement guarantee; validation and opening should be bound to the same filesystem objects.

[gschier]

Acceptable risk for this feature

[gschier]

@greptile-apps please review the latest changes.

Dismissed because a newer commit was pushed; Greptile will re-review the current head.