Serialize concurrent rewrites of schema test files - #28
Merged
Merged
Conversation
berkbaydur
approved these changes
Jul 22, 2026
Use an exclusive file lock for each read-modify-write cycle _and_ a mutex to account for multi-threaded scenarios. This prevents parallel test execution from overwriting changes from another process/thread. Add a concurrency test for the locked rewrite helper.
GabrielNagy
force-pushed
the
parallel-safe-rewrite
branch
from
July 22, 2026 14:49
bfe017c to
0fd55cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an exclusive file lock for each read-modify-write cycle. This prevents parallel test processes from overwriting changes from another process.
Add a concurrency test for the locked rewrite helper.