Skip to content

Fixed some logic around queue task pickup #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djthorpe merged 1 commit into from
Jun 16, 2026
Merged

Fixed some logic around queue task pickup #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pgqueue/manager/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ func (manager *Manager) Run(ctx context.Context, log *slog.Logger) error {

// Process as many tasks as we have capacity for, until there are
// no more tasks or an error occurs.
processed := false
for i := 0; i < runtime.GOMAXPROCS(0); i++ {
// Get next task for the queue
Comment on lines +86 to 88
var task *schema.Task
Expand All @@ -94,13 +95,16 @@ func (manager *Manager) Run(ctx context.Context, log *slog.Logger) error {
if err != nil {
return false, err
} else if task == nil {
// No more tasks
return false, nil
// No more tasks can be retained right now. If we processed at
// least one task in this pass, ask the scheduler to check again
// soon to keep draining the queue.
return processed, nil
}

// Run the task callback - results are logged in the callback,
// so we don't need to do anything with them here.
manager.queues.RunQueueTask(child, task, results)
processed = true
}

// Return success
Expand Down
Loading