Repository navigation
Replace custom image loading with cached_network_image - #1717
Merged
Merged
Conversation
kevmo314
had a problem deploying
to
ios-testflight
October 26, 2026 03:21 — with
GitHub Actions
Error
kevmo314
temporarily deployed
to
android-internal
October 26, 2026 03:21 — with
GitHub Actions
Inactive
kevmo314
temporarily deployed
to
android-internal
October 26, 2026 03:29 — with
GitHub Actions
Inactive
kevmo314
marked this pull request as ready for review
October 26, 2026 03:29
kevmo314
had a problem deploying
to
ios-testflight
October 26, 2026 03:31 — with
GitHub Actions
Error
kevmo314
temporarily deployed
to
android-internal
October 26, 2026 03:36 — with
GitHub Actions
Inactive
kevmo314
temporarily deployed
to
ios-testflight
October 26, 2026 03:37 — with
GitHub Actions
Inactive
kevmo314
temporarily deployed
to
ios-testflight
October 26, 2026 04:53 — with
GitHub Actions
Inactive
kevmo314
temporarily deployed
to
android-internal
October 26, 2026 04:53 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the custom network image loader and disk-only placeholder provider with
CachedNetworkImageProviderthroughout chat, emote input/autocomplete/picker, badges, avatars, and previews. Cached images display immediately while stale entries refresh through the library. Existing dimensions, fades, transparent placeholders, and chat emote text fallbacks are preserved; animated image bytes are not resized or re-encoded.Replaces #1715. The dependency is installed from kevmo314/flutter_cached_network_image at commit
4c24ee00b4fe69144a37e2cd4067eb74eabf1348, pinned in bothpubspec.yamlandpubspec.lock. That commit fixes an undisposed queued animation frame in published 4.0.5. The fix is submitted upstream as Baseflow/flutter_cached_network_image#1065, with five regression tests and all 56 upstream tests passing. Switch back to a hosted dependency once the fix is released.Validation
flutter pub get: resolves the actual Git dependency from the pinned fork commit, with no local dependency overrides.flutter test --no-pub: all 493 tests pass, including the image leak checker.flutter analyze --no-pub: passes.dart format --output=none --set-exit-if-changed .: passes.The image tests use Flutter's real decoder and real temporary disk files with controlled HTTP responses. Android/iOS device smoke tests were not run locally; native builds are covered by PR CI.
History
The available non-shallow git history and GitHub issue search contain no earlier
cached_network_imageusage. The custom loader was introduced by #439 in May 2022, replacingflutter_image/NetworkImageWithRetryto address #403's network-failure, retry, caching, and placeholder requirements. Those records do not identify a prior format-support problem; GIF and animated WebP playback are explicitly tested here.