Fix the deprecated std::binary_function in the implementation of the std::sort custom comparator#217
Merged
Conversation
Contributor
Author
|
p.s. I would have preferred using the std comparators instead, but those operate on std::string parameters (the RPackage name() returns char * instead). |
andy128k
reviewed
Jul 6, 2026
amaa-99
force-pushed
the
90-fix-the-deprecated-stdbinary_function-in-the-implementation-of-the-stdsort-custom-comparator
branch
2 times, most recently
from
46cd730 to
430d500
Compare
andy128k
reviewed
Jul 6, 2026
andy128k
reviewed
Jul 6, 2026
amaa-99
force-pushed
the
90-fix-the-deprecated-stdbinary_function-in-the-implementation-of-the-stdsort-custom-comparator
branch
2 times, most recently
from
3d70d4d to
da12987
Compare
Owner
|
This looks fine to me, if @andy128k is also happy I will merge :) |
amaa-99
force-pushed
the
90-fix-the-deprecated-stdbinary_function-in-the-implementation-of-the-stdsort-custom-comparator
branch
from
da12987 to
267f652
Compare
…std::sort custom comparator: Replaced the implementation with one based on std::function.
amaa-99
force-pushed
the
90-fix-the-deprecated-stdbinary_function-in-the-implementation-of-the-stdsort-custom-comparator
branch
from
267f652 to
a4b098a
Compare
amaa-99
deleted the
90-fix-the-deprecated-stdbinary_function-in-the-implementation-of-the-stdsort-custom-comparator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the implementation with one based on std::function.
(closes amaa-99#91)