Skip to content

Align CvssScore handling with Cve and update dependencies#438

Merged
ybelMekk merged 2 commits into
mainfrom
feat/cve-cvss-score-alignment
May 13, 2026
Merged

Align CvssScore handling with Cve and update dependencies#438
ybelMekk merged 2 commits into
mainfrom
feat/cve-cvss-score-alignment

Conversation

@ybelMekk
Copy link
Copy Markdown
Contributor

@ybelMekk ybelMekk commented May 13, 2026

Vulnerability Data Handling:

  • Changed the CvssScore field in the toImageVulnerability function to use the value from v.GetCve().CvssScore instead of the top-level v.CvssScore, ensuring the score is sourced from the correct place.
  • Updated test and fake data to consistently set the CvssScore on both the vulnerability and its nested Cve struct, improving test accuracy and alignment with production data.

Testing and Fakes:

  • Added a stub implementation of SuppressVulnerabilities to the fakeVulnerabilitiesClient for use in tests, supporting future test scenarios that require this method.

- transform.go: CvssScore leses nå fra v.GetCve().CvssScore
- workload_v13s.go og test: test-fixtures setter CvssScore på Cve i tillegg til
  wrapper for konsistens med ny proto-semantikk
@ybelMekk ybelMekk requested a review from a team as a code owner May 13, 2026 12:18
@ybelMekk ybelMekk force-pushed the feat/cve-cvss-score-alignment branch from cf0a01a to 8ec9ac0 Compare May 13, 2026 12:33
@ybelMekk
Copy link
Copy Markdown
Contributor Author

må vente på: nais/v13s#291 men er klar til review

Copy link
Copy Markdown
Contributor

@thokra-nav thokra-nav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kjør på når det er klart :)

…nment SHA

- Legg til SuppressVulnerabilities i fake-klienten (ny metode i Client-interface)
- go mod tidy
@ybelMekk ybelMekk force-pushed the feat/cve-cvss-score-alignment branch from 8ec9ac0 to 81dd04c Compare May 13, 2026 13:34
@ybelMekk ybelMekk merged commit 4500567 into main May 13, 2026
10 checks passed
@ybelMekk ybelMekk deleted the feat/cve-cvss-score-alignment branch May 13, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants