ci: [SC-66825] run zizmor and fix GitHub Actions findings - #10
Merged
Conversation
…flow backup.yml checks out the repo and then mirrors the whole workspace, including .git/, to narrative-backups-prod. Without persist-credentials: false, actions/checkout leaves the job token in .git/config as an extraheader, so every daily backup wrote a GitHub credential into S3. Also switches the GITHUB_TOKEN env var from secrets.GITHUB_TOKEN to the github.token context. The context form always resolves in a called workflow, so callers no longer need 'secrets: inherit' to make it work — which lets backup-daily.yml drop 'secrets: inherit' (zizmor secrets-inherit) and scope itself to permissions: contents: read (zizmor excessive-permissions). Callers are unaffected: backup.yml declares no inputs and no secrets, so its call signature is unchanged. All 84 live callers remain valid whether or not they pass 'secrets: inherit'. sc-66825
Modeled on narrative-skills-marketplace/.github/workflows/zizmor.yml
(PR #108): permissions: {} at the top level, per-job permissions scoped
to what upload-sarif needs, and SARIF published to code scanning.
common-github hosts reusable workflows consumed by 82 repos, so a
regression here has org-wide blast radius — this catches it at PR time.
sc-66825
contents: write and pull-requests: write were granted at the workflow
level, so they would apply to any job added later. Moves them onto the
release-please job with a comment per scope, leaving permissions: {} at
the top level (zizmor excessive-permissions, pedantic persona).
No behavior change: the workflow has a single job.
sc-66825
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This was referenced Aug 17, 2026
mbabic
changed the title
mbabic
force-pushed
the
chore/sc-66825/zizmor-ci-and-actions-hardening
branch
from
August 18, 2026 20:33
33576a7 to
9634f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs zizmor in CI and fixes the three findings it reports. First repo in sc-66825 —
common-githubgoes first because its reusable workflows are consumed org-wide.Modeled on
narrative-skills-marketplacePR #108, which is the reference implementation for this ticket.Findings fixed
artipackedpersist-credentials: falseonactions/checkoutinbackup.ymlsecrets-inheritsecrets: inheritfrombackup-daily.ymlexcessive-permissionspermissions: contents: readonbackup-daily.ymlPlus two
excessive-permissionsfindings that only surface at--persona=pedantic, fixed inrelease-please.ymlby moving its write scopes from the workflow level onto the job.No suppressions were added. All findings are genuinely fixed.