16 fpe code doesn t work on mac by jman025 · Pull Request #68 · nasa/cml

jman025 · 2026-07-23T14:29:59Z

No description provided.

Added function to cml_unit_sim.mk so that the -Wno-nonnull-compare only gets added to TRICK_C/XXFLAGS in a Linux environment as the compile flag is not compatible with Clang Fixed overloading and fpe compile errors for SIM_Test_table. Using SIM_Test_table as the test case to get Mac working with CML. Currently seeing SWIG error where SWIG is attempting to access private things within a class. Refs #16

…D=1 on Mac Also includes #ifdef SWIG fix for swig attempting to access private class information Refs #16

ninotarantino · 2026-07-23T15:05:09Z

This is a few commits behind so go ahead and rebase or merge main into this branch first.

Refs #16

ninotarantino · 2026-08-10T19:05:42Z

   ExtendedPlanetaryDerivedState();
   ~ExtendedPlanetaryDerivedState() override = default;
-
+   using SubscriptionBase::initialize;


Quick note about these before you go too far down this rabbit hole: this is downstream from #27. We're better off ignoring the warning generated by overloading virtual functions for now with (off the top of my head) -Wno-error=overloaded-virtual, we don't want to make this change. This doesn't trip up on Linux for now because -Woverloaded-virtual isn't included in -Wall in GCC 8.5, but it is in newer GCCs.

The reason we don't want to make this change is because that SubscriptionBase::initialize function is intended to be overridden. If we added this, users would be able to call the wrong initialize() method as opposed to the overloaded one with arguments in some of these models. There's some architectural work that needs to happen to address that warning, so it'll definitely be its own PR in the future. I think the solution will probably be something along the lines of making SubscriptionBase::initialize a method named something like initialize_subscription() and not virtual, but I haven't spent time thinking about the ramifications yet.

Branch works on Linux as well. Refs #16

ninotarantino · 2026-08-14T18:28:52Z

        -Walloca
        -Wcast-align
        -Wcast-qual
-        -Wduplicated-branches


For this file I'm tempted to say let's just return at the start of the function if the compiler isn't GCC and keep the rest as it was before. Most contributions to CML currently come from people using GCC on Rocky 8 and if they can't easily reproduce mac-only warnings, that'll be difficult to deal with. Maybe we'll add mac warnings in the future though.

ninotarantino · 2026-08-14T18:29:32Z

+    # We need to know what TRICK_HOST_CPU is to find the libraries, so get that first
+    cmd = ( os.path.join(args.trick, 'bin/trick-gte') + " TRICK_HOST_CPU")
+    sys.path.append(os.path.abspath(os.path.join(args.trick, 'share/trick/trickops/')))
+    from WorkflowCommon import run_subprocess
+    trick_host_cpu = run_subprocess(command=cmd,m_shell=True).stdout.strip().split("\n")[-1]
+    if "Linux" in trick_host_cpu:
+        trick_build_lib_dir = "lib64"
+    elif "Darwin" in trick_host_cpu:
+        trick_build_lib_dir = "lib"
    if not args.trick or not os.path.exists(args.trick):
        msg = ("Unable to locate trick directory. Define TRICK_HOME in your environment"
          " or use --trick=/path/to/trick/ to specify a path to a pre-built Trick"
          " directory (Requires version 19.5.1 or later)")
        raise RuntimeError(msg)
-    if (not os.path.exists(os.path.join(args.trick, 'lib64')) or
-        not os.listdir(os.path.join(args.trick,'lib64'))):
+    if (not os.path.exists(os.path.join(args.trick, trick_build_lib_dir)) or
+        not os.listdir(os.path.join(args.trick, trick_build_lib_dir))):


Let's just remove this entire section that checks if Trick exists. It'll be immediately obvious if it doesn't when you run the script regardless, there's no need to maintain extra code to check for it.

ninotarantino · 2026-08-14T18:32:42Z

 TRICK_LDFLAGS += -L${CML_LIBRARY_DIR}
 ifeq (1, $(CML_USE_STATIC_LIB))
    TRICK_LDFLAGS += -l:libcml.a
+else ifeq ($(findstring Darwin,$(trick-gte TRICK_HOST_CPU)),)


Could probably just make this a direct comparison with Darwin using trick-gte TRICK_HOST_TYPE instead.

ninotarantino · 2026-08-14T18:35:21Z

+TRICK_CFLAGS += -g -I. -Wall -Wextra -Werror -Wno-implicit-fallthrough -Wno-format-truncation -Wno-int-in-bool-context -Wno-address
+TRICK_CXXFLAGS += -g -I. -Wall -Wextra -Werror -Wno-implicit-fallthrough -Wno-format-truncation -Wno-int-in-bool-context -Wno-address


These should have already been removed in this file along with the Wno-nonnul-compare. l I think this branch is a bit behind. Try rebasing or merging main and reverting the changes to this file first. We can probably essentially get rid of every change in here.

ninotarantino · 2026-08-14T18:35:57Z

  RangeComputation(const jeod::PlanetFixedPosition & state_in);
  ~RangeComputation() override = default;

+  using SubscriptionBase::initialize;


These all still need to be removed.

ninotarantino · 2026-08-14T18:41:59Z

+#ifdef SWIG
+%immutable;
+#endif


I added these in the Rocky 9 compatibility branch which was just merged. Go ahead and revert the ones on this branch and see if the ones I added are enough to get builds on mac working.

ninotarantino · 2026-08-14T18:42:48Z

    // and the inverse of the decomposed matrix is arithmetically simple to
    // compute.
-    double C_inv[dimension][dimension] = {0};
+    double C_inv[dimension][dimension] = {{0}};


Can be simplified, the zero is redundant in the first place.

Suggested change

double C_inv[dimension][dimension] = {{0}};

double C_inv[dimension][dimension] {};

ninotarantino · 2026-08-14T18:43:39Z

                       const double failed_val,
                       const bool   failed_flag)
 {
+  fenv_t env;


Suggested change

fenv_t env;

std::fenv_t env;

Ditto further down in this file, we should be using the C++ std::feholdexcept and std::fesetenv.

ninotarantino · 2026-08-14T18:45:31Z

  public:
   double            independent;
-   double            dependent[11][2]; // (--) 11 tables, 2 data per table
+   double            dependent[12][2]; // (--) 11 tables, 2 data per table


Don't forget to update the comment.

Suggested change

double dependent[12][2]; // (--) 11 tables, 2 data per table

double dependent[12][2]; // (--) 12 tables, 2 data per table

ninotarantino · 2026-08-14T18:46:20Z

-ifeq ($(shell pkg-config --exists libxml-2.0 && echo $$?),0)
-    export TRICKIFY_CXX_FLAGS += $(shell pkg-config libxml-2.0 --cflags)
-endif


This is probably going to cause the Rocky build to fail because it won't be able to find libxml types that the headers need.

Otney Boyd Crawford added 2 commits June 24, 2026 14:43

Updates to get SIM_Test_table to compile with trick-CP CML_TRICK_BUIL…

531d849

…D=1 on Mac Also includes #ifdef SWIG fix for swig attempting to access private class information Refs #16

jman025 assigned ninotarantino Jul 23, 2026

ninotarantino self-requested a review July 23, 2026 15:04

ninotarantino assigned jman025 and unassigned ninotarantino Jul 23, 2026

Otney Boyd Crawford added 3 commits August 3, 2026 16:38

Changes that generates libcml.dylib and the trickified cml library

625178b

Refs #16

Merge branch 'main' into 16-fpe-code-doesn-t-work-on-mac

688818c

Able to build all 104 unit sims on Mac

74c72c5

Refs #16

ninotarantino reviewed Aug 10, 2026

View reviewed changes

Updates to get all unit sims to run on Mac.

e9e55db

Branch works on Linux as well. Refs #16

ninotarantino requested changes Aug 14, 2026

View reviewed changes

Navigation Menu

Uh oh!

16 fpe code doesn t work on mac - #68

16 fpe code doesn t work on mac#68
jman025 wants to merge 6 commits into
mainfrom
16-fpe-code-doesn-t-work-on-mac

jman025 commented Jul 23, 2026

Uh oh!

ninotarantino commented Jul 23, 2026

Uh oh!

ninotarantino Aug 10, 2026 •

edited

Loading

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

ninotarantino Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		TRICK_CFLAGS += -g -I. -Wall -Wextra -Werror -Wno-implicit-fallthrough -Wno-format-truncation -Wno-int-in-bool-context -Wno-address
		TRICK_CXXFLAGS += -g -I. -Wall -Wextra -Werror -Wno-implicit-fallthrough -Wno-format-truncation -Wno-int-in-bool-context -Wno-address

	double C_inv[dimension][dimension] = {{0}};
	double C_inv[dimension][dimension] {};

	double dependent[12][2]; // (--) 11 tables, 2 data per table
	double dependent[12][2]; // (--) 12 tables, 2 data per table

Uh oh!

Conversation

jman025 commented Jul 23, 2026

Uh oh!

ninotarantino commented Jul 23, 2026

Uh oh!

ninotarantino Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ninotarantino Aug 10, 2026 •

edited

Loading