Replace the packaged 32-bit updater with the signed x64 build from vicius v1.16.1 - #174
Merged
Merged
Conversation
….16.1. The updater bundled in 72ffcfc came from the vicius v1.16.0 release, which published a 32-bit binary under an architecture-neutral asset name because all three build architectures collapsed onto the same release asset. The packaged nefarius_BthPS3_Updater.exe was therefore an i386 image. v1.16.0 has been withdrawn. This is the x64 UPX-packed executable from vicius v1.16.1, which ships architecture-specific archives; it is byte-identical to example_Demo_Updater_packed.exe in vicius-x64.zip (sha256 1fbf3b4aea4327958e00a8739bd7d30d8777470526a9529941e9f7065204f8e9) and Authenticode signed. The x64 build also runs fine under ARM64 emulation, so one binary still covers both installer targets. Co-authored-by: Cursor <cursoragent@cursor.com>
build/SetupRelease.Tests.ps1 builds a cabinet fixture, and makecab writes setup.inf and setup.rpt into the working directory, so running the suite leaves two untracked files in the repository root. /Setup/setup.inf and /Setup/setup.rpt were already ignored for the Advanced Installer directory; this covers the root-level copies. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ChangesMakecab fixture output handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
A rabbit checks the buildroom floor Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
masterpackages a 32-bit updater. Commit 72ffcfc bundled the executable from the vicius v1.16.0 release, but that release was broken: all three build architectures produce an identically namedexample_Demo_Updater.exe, they were uploaded as loose release assets, and GitHub's flat asset namespace collapsed them onto one name. The x86 build won the upload race, so the "v1.16.0 updater" was an i386 image.Verified against the file currently on
master:vicius v1.16.0 has since been withdrawn, and v1.16.1 replaces it with architecture-specific archives plus a CI guard that reads each executable's PE machine type and refuses to publish a mismatch (nefarius/vicius#209).
No shipped installer is affected. The newest release, setup-v2.17.0, predates 72ffcfc by well over a year, so this never reached users.
Change
BthPS3Installer/nefarius_BthPS3_Updater.exeis replaced with the x64 UPX-packed executable fromvicius-x64.zipof v1.16.1. The x64 build runs correctly under ARM64 emulation, so a single binary still covers both installer targets and no per-architecture layout is needed.That hash is byte-identical to the asset downloaded from the release, not a local rebuild. The LFS pointer committed here records the same oid.
A second commit gitignores
setup.infandsetup.rpt.build/SetupRelease.Tests.ps1builds a cabinet fixture and makecab writes those two files into the working directory, so running the suite leaves untracked files in the repository root. The/Setup/equivalents were already ignored.Verification
NV_FILENAME_REGEX, resolvingnefarius/BthPS3for the update URL — a rename that broke this would silently send the updater to the wrong endpoint.build/SetupRelease.Tests.ps1passes.Assert-BthPS3NoGitLfsPointerspasses against the real working tree, all 5 LFS-tracked payload binaries materialised (not pointer stubs).Summary by CodeRabbit