Feature/implement default quota for groups

[hefftich]

• Resolves:
  Implement a default quota per group. groupfolders#5029

Summary

We need a way for admins to set default quotas for team folder creation, based on group membership. This needs a group -> quota mapping in the Teams admin settings.

Admin settings --> Teams

• In the Team settings, admins can add entries to a table, defining default quotas for groups.
• When a user creates a new team, the highest quota of the groups, this user is a member of, gets applied to the new Team folder.
• At least a line for "all" is always present in the table, which is applied at team creation, when the user isn't a member of any other quota group.
• The three-dot menu lets admins delete any mapping, despite "all".
• The quotas only get applied at team creation. An admin can alway change the quota of existing teams later on.

group | default quota | options -- | -- | -- all | 100 MB |   marketing | 2 GB | ... sales | 10 GB | ... engineering | 5 GB | ...

Examples

• Bob is a member in the groups marketing and engineering. He creates a new team, which gets a quota of 5 GB.
• Alice is not a member of any groups defined in this list. Her newly created team gets a quota of 100 MB.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• [] Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/teams/api.ts	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[hefftich]

/backport to stable35

[jospoortvliet]

Hi,

I did some testing. The Team specific quota - that should be GROUP specific, so this can be managed from LDAP.

We should also add an explanation text. Maybe:

"Choose the default quote assigned to a Team folder created by users based on group membership. The default quota for a new Team folder is always the highest from the default quotas assigned to any of the groups a user is member of."

The current teas-based implementation does largely work, but there is one issue.

What I tested:

I created a 'Sales Team', then assigned 2 users to it. Then, in admin settings for Teams, assigned that team a higher default quota:

Then I let one of those users create a new team. This shows up correctly under Teamfolders in the Teamfolders (to be Groupfolders) app, with the higher default quota:

(it is Sales Team EMEA, which got 5GB of storage quota, as intended).

But in the Teams app, the folder created by this user does not show:

Choosing 'add' gives a error:

... but I guess perhaps a specific branch of the groupfolders app has to be checked out for all this to properly work.

If so, disregard the broken part. We should of course still fix the team vs group thing.

[marcoambrosini]

that should be GROUP specific, so this can be managed from LDAP

@jospoortvliet I think we should also allow teams here, more flexible for everyone. But agree that we need groups

for example: if you already have a "management" team, it's useful to be able to use that for trusting the members with a higher quota, instead to having to recreate that to a group. What do you think?

[jospoortvliet]

that should be GROUP specific, so this can be managed from LDAP

@jospoortvliet I think we should also allow teams here, more flexible for everyone. But agree that we need groups

for example: if you already have a "management" team, it's useful to be able to use that for trusting the members with a higher quota, instead to having to recreate that to a group. What do you think?

I don't think supporting teams is a problem - for small orgs it makes sense. Big orgs will likely want this in LDAP where other policies are handled, too, so groups would be the basis I think.

[hefftich]

@jospoortvliet The issue in the 3rd screenshot is a bug in the groupfolders project.
i created a pr: nextcloud/groupfolders#5086

[Fin-c]

@jospoortvliet I’ve fixed the bug relating to adding folders to existing teams that don’t yet have a team space #2890