Repository navigation
Conversation
6 of 7 tasks
luka-nextcloud
approved these changes
Oct 22, 2026
luka-nextcloud
left a comment
luka-nextcloud
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I left one minor comment.
hefftich
force-pushed
the
fix/reference-board-embedding
branch
from
October 28, 2026 13:11
878363d to
ee54f79
Compare
- Allow interactive board widgets to run within a host app without accessing Deck's router or changing the host's page title. - Track widget instances by their mount elements and clean up their Vue apps, Pinia stores and board sessions when destroyed. Handle overlapping board reloads and widgets destroyed during asynchronous setup. - Keep Text editor instances outside Vue reactivity and clean them up when card details are closed, including editors still being created. Co-authored-by: Copilot <copilot@github.com> GPT-6.1 Sol Signed-off-by: Stefan Lender <Stefan.Lender@dataport.de>
hefftich
force-pushed
the
fix/reference-board-embedding
branch
from
October 28, 2026 13:26
ee54f79 to
7feee7c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Display the team Deck boards within the Teams app circles#2948
Relates:
Embed shared resources using the reference widget API circles#3055
Summary
Fix lifecycle handling for interactive Deck board reference widgets embedded in other Nextcloud apps.
Embedded boards must work independently of Deck's router and must not change the host app's page title. Widget instances also need to be isolated and cleaned up reliably when references are removed, re-rendered, or destroyed during asynchronous initialization.
This PR:
TODO
Checklist
🤖 AI (if applicable)